Page MenuHomeIn-Portal Phabricator

INP-1560 Migrate "mysql" to "mysqli" database type during upgrade
ClosedPublic

Authored by erik on Jul 4 2016, 5:06 AM.

Details

Summary

Replaced "mysql" to "mysqli" on installation process

Test Plan
  1. drop all tables in the 5.2.x database
  2. copy all 5.2.1 project's database tables to the 5.2.x project's database
  3. delete system/config.php file from the 5.2.x project
  4. copy system/config.php file from 5.2.1 project to 5.2.x project
  5. confirm, that copied file contain 'mysql' among values of configuration variables and do not contain 'mysqli' there
  6. in the system/config.php file change value of $_CONFIG['Database']['DBName'] configuration variable from 5.2.1 project's database name to 5.2.x project's database name
  7. in the system/config.php file change value of $_CONFIG['Misc']['WebsitePath'] configuration variable from 5.2.1 project's base path to 5.2.x project's base path
  8. in the command-line run command chmod 777 system/config.php
  9. in the browser open core/install.php of 5.2.x project
  10. confirm that system/config.php file contains 'mysqli' in place of recent 'mysql' value

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik updated this revision to Diff 543.Jul 4 2016, 5:06 AM
erik retitled this revision from to INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): INP-1560.
alex requested changes to this revision.Jul 4 2016, 5:45 AM
alex edited edge metadata.
alex added inline comments.
core/install.php
294–305 ↗(On Diff #543)

Thank you, but please revert these changes.


Random CS fixes to unrelated code does more harm than good.

307 ↗(On Diff #543)

Please also check, that DBType is mysql currently.


The config is changed (even to same value) on each installator visit.

This revision now requires changes to proceed.Jul 4 2016, 5:45 AM
erik updated this revision to Diff 544.Jul 5 2016, 4:30 AM
erik edited edge metadata.

Removed CS fixes, added condition for DBType update.

alex requested changes to this revision.Nov 16 2016, 4:51 AM
alex edited edge metadata.

Please rebuild this patch for In-Portal 5.2.x.

This revision now requires changes to proceed.Nov 16 2016, 4:51 AM
erik edited the test plan for this revision. (Show Details)Dec 2 2016, 4:30 AM
erik edited edge metadata.
erik updated this revision to Diff 656.Dec 2 2016, 4:43 AM
erik edited edge metadata.

Rebuilt in In-Portal 5.2.x.

alex accepted this revision.Jun 11 2020, 4:59 AM
This revision is now accepted and ready to land.Jun 11 2020, 4:59 AM
This revision was landed with ongoing or failed builds.Mar 16 2021, 3:33 AM
This revision was automatically updated to reflect the committed changes.