In D551#11256, @erik wrote:

2. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.

2. \NParserCompiler::FindTemplateFiles - recompile all templates from the System Tools section - first convertPathToRelative call is with $path = /core/admin_templates parameter, so no comversion happens - incoming path already is relative. However, result is relative path, so test is passed.

Reverted change from array_merge into += during template parser mass-compilation error displaying.

Added color names in comments.

Improve handling of log levels, that doesn't require coloring.

All task-defined coloring is right.

"use the above-created user and products (several with different quantities)"

Cosmetic change.

Without this change - also no SQL error. Maybe, because no MySQL 8.x in the test system.

In D546#11169, @erik wrote:

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

after "use the Clear Templates Cache functionality"
system/cache/core/admin_templates folder is present and has drwxr-xr-x permissions, but system/cache/core/admin_templates/config folder is not present, and system/cache/core/admin_templates/config/config_universal.php file is not present.

under system/cache/core/admin_templates folder are present only incs folder and and tools folder

after "Compiled Template Permission Mode" is changed, system/cache/core/admin_templates/tools folder disappears and system/cache/core/admin_templates/config folder is created, so all other test plan checks are passed.

failed parts 1.10, 1.11. (in both clean install and upgrade cases)

Use "la_fld_LogServerHostname" phrases (existing) instead of "la_fld_ServerHostname" (non-existing) in the Session Log grid.

In the D539 added another phrase. Phrase la_fld_ServerHostname is detected as missing during tests.

In D542#11101, @erik wrote:

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Extracted Arcanist integration into a separate Differential Revision.

Rename test file/class to make Phabricator understand PHPUnit test results/coverage.

Replaced assertEquels with assertSame in all tests, added in this revision.

Added test case when pounds and ounces both are zero.

Made all requested fixes. Created tests for kUbitFormatter class.

Also try to modify tested code to confirm, that related tests would fail.

Changed ligic, added unit tests.

Let's implement this the other way around (sender does type casting, but recipient throws an exception on error on any PHP version):