Page MenuHomeIn-Portal Phabricator

INP-1457 - Clear template parser state before parsing "404 Not Found" template
ClosedPublic

Authored by alex on Aug 12 2015, 3:44 AM.

Details

Test Plan
NOTE: Test needs to be performed on advanced theme.
  1. enable mod-rewrite
  2. comment-out page_title block definition in error_notfound.tpl
  3. type any non-existing page url in the browser and press ENTER
  4. confirm, that:
    • the 404 Not Found page is displayed
    • browser tab title ends up with :: Page Not Found
  5. disable mod-rewrite
  6. create a product in Admin Console
  7. on the Front-End open that product detail page
  8. in url change id of product to some other number, that doesn't match to any existing product id
  9. confirm, that:
    • the 404 Not Found page is displayed
    • browser tab title ends up with :: Page Not Found (before it ended with :: because page_title block from product detail page was used)

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 246.Aug 12 2015, 3:44 AM
alex retitled this revision from to INP-1457 - Clear template parser state before parsing "404 Not Found" template.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1457.
glebs accepted this revision.Sep 9 2015, 2:12 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2015, 2:12 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:07 AM
alex added a project: Restricted Project.