Unexpected output: Affected paths: relative - resubmit patch.
⚙ D110 INP-1460 - Check if object is castable to string in the "m_PrintCurrentParams" tag
Page MenuHomeIn-Portal Phabricator
Differential D110

INP-1460 - Check if object is castable to string in the "m_PrintCurrentParams" tag
ClosedPublic
Actions

Authored by alex on Aug 15 2015, 2:54 AM.

Details

Reviewers
glebs
Commits
rINP16271: Fixes INP-1460 - In "m_PrintCurrentParams" tag check if object is castable to…
Test Plan
  1. create element (via m_DefineElement tag), that would contain only <inp2:m_PrintCurrentParams/> tag inside
  2. create new tag, that will:
    • define empty $block_params array
    • get currently logged-in user object
    • assign it to user key in $block_params array
    • include /core/ckeditor/ckeditor_php5.php file
    • create instance of CKEditor class
    • assign it to the editor key in $block_params array
    • render previously created block name
    • return rendering result from the tag
  3. confirm, that:
    • no Fatal Error happens
    • among printed results there will be:
      • user = "ClassName: UsersItem; PrefixSpecial: u"
      • editor = "ClassName: CKEditor" (before this line won't be printed)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 80
Build 80: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 250.Aug 15 2015, 2:54 AM
alex retitled this revision from to INP-1460 - In "m_PrintCurrentParams" tag check if object is castable to string.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1460.
glebs accepted this revision.Sep 10 2015, 1:28 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2015, 1:28 AM
Closed by commit rINP16271: Fixes INP-1460 - In "m_PrintCurrentParams" tag check if object is castable to… (authored by alex). · Explain WhySep 27 2015, 5:00 AM
This revision was automatically updated to reflect the committed changes.
alex retitled this revision from INP-1460 - In "m_PrintCurrentParams" tag check if object is castable to string to INP-1460 - Check if object is castable to string in the "m_PrintCurrentParams" tag.Jul 16 2016, 7:10 AM
alex edited edge metadata.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 125016206Aug 15 2015, 2:54 AM
★
★
Diff 233616270Commit rINP16271Sep 27 2015, 5:00 AM
★
★

Diff 250

View Options

core/kernel/processors/main_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server