Unexpected output: Affected paths: relative - resubmit patch.
⚙ D135 INP-1482 - Add "ConsoleIO" class
Page MenuHomeIn-Portal Phabricator
Differential D135

INP-1482 - Add "ConsoleIO" class
ClosedPublic
Actions

Authored by alex on Sep 20 2015, 8:02 AM.

Details

Reviewers
glebs
Commits
rINP16282: Fixes INP-1482 - Add "ConsoleIO" class
Test Plan
  1. run every possible console command with every possible argument
  2. confirm, that no Fatal Error or Exception happens and command does what it needs to

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint ErrorsExcuse: Will be fixed other time through mass license replacement
Unit
No Unit Test Coverage
Build Status
Buildable 152
Build 152: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 313.Sep 20 2015, 8:02 AM
alex retitled this revision from to INP-1482 - Add "ConsoleIO" class.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1482.
alex updated this revision to Diff 315.Sep 20 2015, 9:09 AM
alex edited edge metadata.
  1. don't use factory for getting ConsoleIO class to avoid dependency loop during classmap:rebuild command run
  2. add <question> output formmatter style to ConsoleIO::choose method like it's done in ConsoleIO::ask method
glebs accepted this revision.Sep 23 2015, 3:17 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 3:17 AM
Closed by commit rINP16282: Fixes INP-1482 - Add "ConsoleIO" class (authored by alex). · Explain WhySep 27 2015, 6:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 131316219Sep 20 2015, 8:02 AM
★
★
Diff 2315162191. don't use factory for getting `ConsoleIO` class to avoid dependency loop during `classmap:rebuild` command runSep 20 2015, 9:09 AM
★
★
Diff 334816281Commit rINP16282Sep 27 2015, 6:12 AM
★
★

Diff 315

View Options

core/install/cache/class_structure.php

Loading...
View Options

core/kernel/Console/Command/AbstractCommand.php

Loading...
View Options

core/kernel/Console/Command/BuildClassMapCommand.php

Loading...
View Options

core/kernel/Console/Command/ResetCacheCommand.php

Loading...
View Options

core/kernel/Console/Command/RunEventCommand.php

Loading...
View Options

core/kernel/Console/Command/RunScheduledTaskCommand.php

Loading...
View Options

core/kernel/Console/ConsoleIO.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server