Unexpected output: Affected paths: relative - resubmit patch.
⚙ D18 MINC-111 - Fix broken primary pricing icon for Subscription Type products
Page MenuHomeIn-Portal Phabricator
Differential D18

MINC-111 - Fix broken primary pricing icon for Subscription Type products
ClosedPublic
Actions

Authored by erik on Oct 30 2014, 1:40 PM.

Details

Reviewers
alex
Commits
rMINC16149: Fixes MINC-111 - Primary pricing icon missing for Subscription Products
Test Plan

Create product with "Subscription" Type. While edit this product, go to "Access & Pricing" tab. Create some record in the grid on "Access & Pricing" tab. See icon in the grid, besides primary pricing record.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

erik updated this revision to Diff 29.Oct 30 2014, 1:40 PM
erik retitled this revision from to Icons moved to core module.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik set the repository for this revision to rINP In-Portal.
erik added 1 JIRA issue(s): MINC-111.
alex set the repository for this revision to rMINC Modules.In-Commerce.Oct 30 2014, 2:56 PM
alex accepted this revision.Oct 30 2014, 3:27 PM
alex edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2014, 3:27 PM
alex requested changes to this revision.Nov 18 2014, 1:39 PM
alex edited edge metadata.

Patch was created against In-Commerce 5.3.x, while associated JIRA task is targeted to In-Commerce 5.2.x. Because of this patch can't be clearly applied.

Please re-create patch against In-Commerce 5.2.x version.

This revision now requires changes to proceed.Nov 18 2014, 1:39 PM
alex added a comment.Nov 23 2014, 3:13 AM

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from Icons moved to core module to MINC-111 - Icons moved to core module.Dec 7 2014, 3:33 PM
alex edited edge metadata.
alex changed the repository for this revision from rMINC Modules.In-Commerce to rINP In-Portal.Dec 7 2014, 3:40 PM
erik edited the test plan for this revision. (Show Details)Mar 18 2015, 5:30 AM
erik updated this revision to Diff 123.Mar 18 2015, 5:31 AM
erik edited edge metadata.

Changed grid configuration to use icons from core module.

alex accepted this revision.Mar 18 2015, 5:48 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2015, 5:48 AM
Closed by commit rMINC16149: Fixes MINC-111 - Primary pricing icon missing for Subscription Products (authored by alex). · Explain WhyMar 21 2015, 7:10 AM
This revision was automatically updated to reflect the committed changes.
alex retitled this revision from MINC-111 - Icons moved to core module to MINC-111 - Fix broken primary pricing icon for Subscription Type products.Jul 16 2016, 6:52 AM
alex edited edge metadata.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 129Oct 30 2014, 12:58 PM
★
★
Diff 212316134Changed grid configuration to use icons from core module.Mar 18 2015, 5:31 AM
★
★
Diff 313716145Commit rMINC16149Mar 21 2015, 7:10 AM
★
★

Diff 29

View Options

modules/in-commerce/units/pricing/pricing_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server