Page MenuHomeIn-Portal Phabricator

INP-1530 - The "Image" tag must set DataExists flag for Template Parser
ClosedPublic

Authored by alex on Feb 2 2016, 9:38 AM.

Details

Test Plan
  • in Admin Console
    1. go to Website & ContentStructure & Data section
    2. go to Products category
    3. switch to Sections tab
    4. use Add toolbar button to add new Sub Products category
    5. switch to Sub Products category using tree in left frame
    6. switch to Products tab
    7. add new Tangible product by using New Product button
  • on the Front-End:
    1. click on Products top menu item
    2. click on Sub Products sub menu item, that appeared
    3. confirm, that created product is shown
    4. click on product to see it's detail page
  • in IDE:
    1. open /themes/advanced/in-commerce/products/product_detail.tpl template
    2. locate <inp2:m_if check="p_ImageSrc" MaxWidth="fullsize"> line
    3. replace whole <inp2:m_if ...> ... </inp2:m_if> tag with <inp2:p_Image render_as="image_element" Primary="1" MaxWidth="thumbnail" DefaultWidth="150" DefaultImage="platform/img/no_picture.gif" align="center"/><br />
  • on Front-End
    1. reload the page
    2. confirm, that default product image is shown
  • in IDE:
    • add data_exists="1" parameter to p_Image tag
  • on Front-End
    1. reload the page
    2. confirm, that default image is shown
  • in IDE:
    1. remove the DefaultImage parameter from p_Image tag
  • on Front-End
    1. reload the page
    2. confirm, that no image is shown
  • in IDE:
    1. remove the data_exists parameter from p_Image tag
  • on Front-End
    1. reload the page
    2. confirm, that no image is shown

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 480.Feb 2 2016, 9:38 AM
alex retitled this revision from to INP-1530 - The "Image" tag must set DataExists flag for Template Parser.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1530.
glebs accepted this revision.Feb 22 2016, 2:29 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Feb 22 2016, 2:29 AM
alex edited edge metadata.Mar 10 2016, 5:14 AM
alex added a project: Restricted Project.
This revision was automatically updated to reflect the committed changes.