Page MenuHomeIn-Portal Phabricator
Differential D19

INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method
ClosedPublic
Actions

Authored by erik on Oct 31 2014, 7:05 AM.

Details

Reviewers
alex
Commits
rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper…
Test Plan

...

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik updated this revision to Diff 30.Oct 31 2014, 7:05 AM
erik retitled this revision from to Removed empty option.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik set the repository for this revision to rINP In-Portal.
erik added 1 JIRA issue(s): INP-1389.

Checked that these options never used in controls like inp_edoit_options. Fields State, BillingState, ShippingState are shown only as inp_edit_box or inp_label.

alex accepted this revision.Nov 21 2014, 4:03 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2014, 4:03 AM
alex added a comment.Nov 23 2014, 3:14 AM

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from Removed empty option to The hardcoded empty option in "CountryStatesHelper::PopulateStates".Dec 7 2014, 8:13 AM
alex edited edge metadata.
alex retitled this revision from The hardcoded empty option in "CountryStatesHelper::PopulateStates" to INP-1389 - The hardcoded empty option in "CountryStatesHelper::PopulateStates".Dec 7 2014, 3:34 PM
alex set the repository for this revision to rINP In-Portal.Dec 7 2014, 3:39 PM
Closed by commit rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper… (authored by alex). · Explain WhyFeb 22 2015, 8:50 AM
This revision was automatically updated to reflect the committed changes.
alex retitled this revision from INP-1389 - The hardcoded empty option in "CountryStatesHelper::PopulateStates" to INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method.Jul 16 2016, 7:26 AM
alex edited the test plan for this revision. (Show Details)

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 130Oct 31 2014, 7:04 AM
★
★
Diff 210916130Commit rINP16131Feb 22 2015, 8:50 AM
★
★

Diff 109

View Options

branches/5.2.x/core/units/helpers/country_states_helper.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server