Differential D204

INP-1539 - Make styleSet name configurable in FCKEditor tag
ClosedPublic
Actions

Authored by alex on Mar 16 2016, 3:30 PM.

Details

Reviewers

glebs

Commits

rINP16382: Fixes INP-1539 - Make styleSet name configurable in FCKEditor tag

Test Plan

NOTE: Use advanced theme for testing.

in Admin Console:
1. go to Website & Content → Browse Website section
2. switch to Content Mode by using button in top frame
3. click on the orange Edit Content (or Edit Content - #1) button
4. in modal window, that opens click on the Styles button on toolbar of CKEditor
5. confirm, that Alex Blue Title style is present and is first in dropdown
6. click Close button in modal window toolbar (not CKEditor toolbar)
in PhpStorm:
1. open /themes/advanced/platform/inc/styles.js file for editing
2. append following to the end of that file and save changes {P6}
3. open /themes/advanced/index.tpl file for editing
4. change <inp2:st_ContentBlock num="1"/> into <inp2:st_ContentBlock num="1" style_set_name="my_styles"/> and save changes
in Admin Console:
1. go to Website & Content → Browse Website section
2. switch to Content Mode by using button in top frame
3. click on the orange Edit Content (or Edit Content - #1) button
4. in modal window, that opens click on the Styles button on toolbar of CKEditor
5. confirm, that Blue Title style is present and is first in dropdown
6. click Close button in modal window toolbar (not CKEditor toolbar)
in PhpStorm:
1. open /themes/advanced/index.tpl file for editing
2. change <inp2:st_ContentBlock num="1" style_set_name="my_styles"/> into <inp2:st_ContentBlock num="1" style_set_name="my_styles" mode="inline"/> and save changes
in Admin Console:
1. go to Website & Content → Browse Website section
2. switch to Content Mode by using button in top frame
3. click inside dashed rectangle that is displayed in place where Edit Content orange button was
4. confirm, that CKEditor appeared inline
5. click on the Styles button on toolbar of CKEditor
6. confirm, that Blue Title style is present and is first in dropdown
in PhpStorm:
1. open /themes/advanced/index.tpl file for editing
2. change <inp2:st_ContentBlock num="1" style_set_name="my_styles" mode="inline"/> into <inp2:st_ContentBlock num="1" mode="inline"/> and save changes
in Admin Console:
1. go to Website & Content → Browse Website section
2. switch to Content Mode by using button in top frame
3. click inside dashed rectangle that is displayed in place where Edit Content orange button was
4. confirm, that CKEditor appeared inline
5. click on the Styles button on toolbar of CKEditor
6. confirm, that Alex Blue Title style is present and is first in dropdown

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.3.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 345
Build 345: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 495.Mar 16 2016, 3:30 PM

alex retitled this revision from to INP-1539 - Make styleSet name configurable in FCKEditor tag.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1539.

Herald added a reviewer: glebs. · View Herald TranscriptMar 16 2016, 3:30 PM

alex edited the test plan for this revision. (Show Details)Mar 16 2016, 4:04 PM

alex edited edge metadata.

renaming parameter "styleset_name" into "style_set_name"
making "style_set_name" parameter also work for regular content blocks (before was working for inline content blocks only)

removing test files added by accident last time

alex added a project: Restricted Project.Mar 17 2016, 8:19 AM

glebs accepted this revision.Apr 18 2016, 2:08 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Apr 18 2016, 2:08 AM

Closed by commit rINP16382: Fixes INP-1539 - Make styleSet name configurable in FCKEditor tag (authored by alex). · Explain WhyJul 25 2016, 4:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/units/helpers/fck_helper.php (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	495	16334		Mar 16 2016, 3:30 PM	★	★
Diff 2	496	16334	- renaming parameter "styleset_name" into "style_set_name"	Mar 16 2016, 4:06 PM	★	★
Diff 3	497	16334	- removing test files added by accident last time	Mar 16 2016, 4:07 PM	★	★
Diff 4	587	16381	rINP16382	Jul 25 2016, 4:14 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 497

View Options

core/units/helpers/fck_helper.php

INP-1539 - Make styleSet name configurable in FCKEditor tagClosedPublicActions