INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons
ClosedPublic
Actions

Authored by alex on Oct 21 2016, 9:35 AM.

Details

Reviewers

erik

Commits

Test Plan

in IDE:
- open /themes/advanced/index.tpl template for editing
- wrap content block tag in there in A tag (e.g. replace <inp2:st_ContentBlock num="1"/> with <a href="http://www.google.com"><inp2:st_ContentBlock num="1"/></a>)
in Admin Console
- go to Website & Content → Browse Website section
- click on Content Mode button in top frame
- click on orange Edit Content button, that represents content block which was wrapped in A tag before
- confirm, that popup/modal window with CKEditor was opened (before fix a redirect to link url would happen)

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Line was already too long before these changes.

Severity	Location	Code	Message
Error	core/kernel/db/db_tag_processor.php:2725	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

No Unit Test Coverage

Build Status

Buildable 474
Build 474: arc lint + arc unit

alex retitled this revision from to INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1588.

alex added a project: Restricted Project.

erik edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2016, 4:07 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	604	16382		Oct 21 2016, 9:35 AM	★	★
Diff 2	642	16475	rINP16476	Nov 25 2016, 5:03 AM	★	★