Unexpected output: Affected paths: relative - resubmit patch.
⚙ D258 INP-1595 - Allow uploading Microsoft Office 2007+ generated files in CKFinder
Page MenuHomeIn-Portal Phabricator
Differential D258

INP-1595 - Allow uploading Microsoft Office 2007+ generated files in CKFinder
ClosedPublic
Actions

Authored by alex on Nov 10 2016, 4:02 AM.

Details

Reviewers
erik
Commits
rINP16480: Fixes INP-1595 - Allow uploading Microsoft Office 2007+ generated files in…
Test Plan
  1. login to Admin Console
  2. go to Website & Content → Structure & Data section
  3. click on Sections tab
  4. open any category for editing
  5. click on icon under Description field to open CKEditor
  6. click on Insert/Edit Document icon on toolbar
  7. click on Browse Server icon
  8. confirm, that it's possible to upload file with any of these extensions: docx,dotx,docm,dotm,xlsx,xltx,xlsm,xltm,xlam,xlsb,pptx,potx,ppsx,ppam,pptm,potm,ppsm

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 484
Build 484: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 610.Nov 10 2016, 4:02 AM
alex retitled this revision from to INP-1595 - Allow uploading Microsoft Office 2007+ generated files in CKFinder.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1595.
alex edited edge metadata.Nov 10 2016, 4:03 AM
alex added a project: Restricted Project.
erik edited edge metadata.Nov 14 2016, 12:57 PM

Tested today docx,dotx,docm,dotm,xlsx,xltx,xlsm,xltm,xlam,xlsb,pptx,potx,ppsx, stuck on finding file sample with ppam extension.

alex added a comment.Nov 14 2016, 1:15 PM
In D258#4885, @erik wrote:

Tested today docx,dotx,docm,dotm,xlsx,xltx,xlsm,xltm,xlam,xlsb,pptx,potx,ppsx, stuck on finding file sample with ppam extension.

  • please also attach files used during testing to linked JIRA issue
  • just a guess, but you can probably create all these files in the MS Office itself via Save As ... feature or similar
erik accepted this revision.EditedNov 16 2016, 4:42 AM
erik edited edge metadata.

Tested. For last 2 extension made fake files - changed extension of another type powerpoint file. All files, used in tests are attached to the related JIRA issue.

This revision is now accepted and ready to land.Nov 16 2016, 4:42 AM
Closed by commit rINP16480: Fixes INP-1595 - Allow uploading Microsoft Office 2007+ generated files in… (authored by alex). · Explain WhyNov 25 2016, 5:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 161016388Nov 10 2016, 4:02 AM
★
★
Diff 264616479rINP16480Nov 25 2016, 5:14 AM
★
★

Diff 610

View Options

core/ckeditor/ckfinder/config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server