Differential D279

INP-1596 - Don't autoload object used in "OnSuggestValues" event
ClosedPublic
Actions

Authored by glebs on Jan 3 2017, 4:16 AM.

Details

Reviewers

alex

Commits

rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event

Test Plan

Login to Admin Console
Go to Logs & Reports → System Log and click Delete All to delete all errors.
Go to Website & Content → E-mail Templates
Try to enter existing template name into Template Name filter input. You should see autocomplete dropdown
Go to Logs & Reports → System Log
Confirm you have no new error messages like 'Requested ID for prefix email-template not passed'
Go to Logs & Reports → System Log and click Delete All to delete all errors.
Go to Configuration → Website → General
click Edit link under Website name setting
delete contents of the Section input
Try to enter i into Section input. You should see autocomplete dropdown
Go to Logs & Reports → System Log
Confirm you have no new error messages like 'Requested ID for prefix email-template not passed'

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 639
Build 639: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 673.Jan 3 2017, 4:16 AM

glebs retitled this revision from to INP-1596 Don't autoload object used in "OnSuggestValues" event.

glebs updated this object.

glebs edited the test plan for this revision. (Show Details)

glebs added 1 JIRA issue(s): INP-1596.

Herald added a reviewer: alex. · View Herald TranscriptJan 3 2017, 4:16 AM

alex retitled this revision from INP-1596 Don't autoload object used in "OnSuggestValues" event to INP-1596 - Don't autoload object used in "OnSuggestValues" event.Jul 22 2022, 7:47 AM

alex edited the test plan for this revision. (Show Details)Jul 22 2022, 8:01 AM

Updating to match current In-Portal version. Also fixing section auto-complete for the system settings.

Harbormaster completed remote builds in B1105: Diff 1073.Jul 22 2022, 8:03 AM

alex accepted this revision.Jul 22 2022, 8:04 AM

This revision is now accepted and ready to land.Jul 22 2022, 8:04 AM

Closed by commit rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event (authored by alex, committed by ). · Explain WhyNov 9 2022, 9:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/db/db_event_handler.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	673	16512		Jan 3 2017, 4:16 AM	★	★
Diff 2	1073	16722	Updating to match current In-Portal version. Also fixing section auto-complete…	Jul 22 2022, 8:03 AM	★	★
Diff 3	1117	16745	rINP16746	Nov 9 2022, 9:36 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 673

View Options

core/kernel/db/db_event_handler.php

INP-1596 - Don't autoload object used in "OnSuggestValues" eventClosedPublicActions