Unexpected output: Affected paths: relative - resubmit patch.
⚙ D303 INP-1699 - Don't cache language/theme while in temp mode
Page MenuHomeIn-Portal Phabricator
Differential D303

INP-1699 - Don't cache language/theme while in temp mode
ClosedPublic
Actions

Authored by alex on May 1 2017, 7:17 AM.

Details

Reviewers
erik
Commits
rINP16583: Fixes INP-1699 - Don't cache language/theme while in temp mode
Test Plan
  1. login to Admin Console
  2. go to Configuration → Website → Regional section
  3. open any language for editing
  4. specify new $body in the HTML Version field
  5. click on General tab to save changes into temporary table
  6. confirm, that value of HTML Version is new $body
  7. close editing window
  8. go to Configuration → Website → Themes section
  9. open any theme for editing
  10. specify 3601 as Language Cache Timeout field value
  11. click on General tab to save changes into temporary table
  12. confirm, that value of Language Cache Timeout field is 3601
  13. close editing window

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not changing to avoid merge conflicts later.
SeverityLocationCodeMessage
Errorcore/units/languages/languages_item.php:306PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Unit
No Unit Test Coverage
Build Status
Buildable 724
Build 724: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 738.May 1 2017, 7:17 AM
alex retitled this revision from to INP-1699 - Don't cache language/theme while in temp mode.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1699.
erik accepted this revision.May 2 2017, 5:15 AM
erik edited edge metadata.
This revision is now accepted and ready to land.May 2 2017, 5:15 AM
Closed by commit rINP16583: Fixes INP-1699 - Don't cache language/theme while in temp mode (authored by alex). · Explain WhyJul 18 2017, 6:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 173816543May 1 2017, 7:17 AM
★
★
Diff 279016577rINP16583Jul 18 2017, 6:34 AM
★
★

Diff 738

View Options

core/units/languages/languages_item.php

Loading...
View Options

core/units/themes/theme_item.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server