Page MenuHomeIn-Portal Phabricator

INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter
ClosedPublic

Authored by alex on Jul 4 2017, 4:24 AM.

Details

Test Plan

Preparations

  • in IDE:
    1. open /core/units/phrases/phrases_config.php
    2. for PhraseType field add more random options so that there are 10 or more
    3. save changes
  • perform clean install

Part 1

  1. go to Admin Console
  2. go to Website & ContentLabels & Phrases section
  3. click on Open Filter link (filter) in Location column
  4. confirm, that:
    • the Search and Close buttons are visible
    • only first part of options are visible
    • there is a scrollbar that provides access to other options

Part 2

  1. perform upgrade from previous version
  2. repeat tests from Part 1

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jul 4 2017, 4:24 AM
alex added a project: Restricted Project.Jul 4 2017, 4:25 AM
erik accepted this revision.Jul 4 2017, 5:46 AM

All right, but when upgrading from 5.1.x to 5.2.x with debugger enabled, got lot of error messages on all installation steps from 1st to 6th. Like "Table SystemLog doesn't exist"

This revision is now accepted and ready to land.Jul 4 2017, 5:46 AM
alex added a comment.Jul 4 2017, 6:30 AM
In D314#6117, @erik wrote:

All right, but when upgrading from 5.1.x to 5.2.x with debugger enabled, got lot of error messages on all installation steps from 1st to 6th. Like "Table SystemLog doesn't exist"

I recommend to create separate discussion about this using this link. It's highly unlikely that change in single SQL caused this behavior.

This revision was automatically updated to reflect the committed changes.