Differential D324

INP-1726 - Add "Source" button to Content Blocks, edited in inline mode
ClosedPublic
Actions

Authored by alex on Aug 3 2017, 5:49 AM.

Details

Reviewers

erik

Commits

rINP16618: Fixes INP-1726 - Add "Source" button to Content Blocks, edited in inline mode

Test Plan

in IDE:
1. open themes/advanced/index.tpl template for editing
2. add mode="inline" attribute to st_ContentBlock tag
3. save changes
in Admin Console:
1. go to Website & Content → Browse Website section
2. click on Content Mode button in top frame
3. confirm, that content block can be edited inline (clicking inside orange frame shows editor toolbar)
4. if in above test Source button was absent on the toolbar then clear all browser cache and reload the page
5. confirm, that Source button is present on the toolbar
6. confirm, that using Source button it is possible to change raw HTML of the content block in new CKEditor dialog (not In-Portal modal window)

Diff Detail

Repository

rINP In-Portal

Branch

branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 814
Build 814: arc lint + arc unit

Event Timeline

alex created this revision.Aug 3 2017, 5:49 AM

Herald added a reviewer: erik. · View Herald TranscriptAug 3 2017, 5:49 AM

erik accepted this revision.Aug 3 2017, 5:57 AM

This revision is now accepted and ready to land.Aug 3 2017, 5:57 AM

Removed all languages, but English.

Closed by commit rINP16618: Fixes INP-1726 - Add "Source" button to Content Blocks, edited in inline mode (authored by alex). · Explain WhyApr 6 2018, 9:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path
M			admin/system_presets/simple/inp_ckconfig.js (4 lines)
M			core/admin_templates/js/inp_ckconfig.js (4 lines)
A	M		core/ckeditor/plugins/sourcedialog/dialogs/sourcedialog.js (79 lines)
A	M	(img)	core/ckeditor/plugins/sourcedialog/icons/hidpi/sourcedialog-rtl.png
A	M	(img)	core/ckeditor/plugins/sourcedialog/icons/hidpi/sourcedialog.png
A	M	(img)	core/ckeditor/plugins/sourcedialog/icons/sourcedialog-rtl.png
A	M	(img)	core/ckeditor/plugins/sourcedialog/icons/sourcedialog.png
A	M		core/ckeditor/plugins/sourcedialog/lang/af.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ar.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/bg.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/bn.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/bs.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ca.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/cs.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/cy.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/da.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/de-ch.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/de.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/el.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/en-au.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/en-ca.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/en-gb.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/en.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/eo.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/es.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/et.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/eu.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/fa.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/fi.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/fo.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/fr-ca.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/fr.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/gl.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/gu.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/he.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/hi.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/hr.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/hu.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/id.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/is.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/it.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ja.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ka.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/km.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ko.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ku.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/lt.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/lv.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/mn.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ms.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/nb.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/nl.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/no.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/pl.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/pt-br.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/pt.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ro.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ru.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/si.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sk.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sl.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sq.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sr-latn.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sr.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/sv.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/th.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/tr.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/tt.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/ug.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/uk.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/vi.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/zh-cn.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/lang/zh.js (9 lines)
A	M		core/ckeditor/plugins/sourcedialog/plugin.js (29 lines)
A	M		core/ckeditor/plugins/sourcedialog/samples/sourcedialog.html (121 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	812	16600		Aug 3 2017, 5:49 AM	★	★
Diff 2	837	16608	Removed all languages, but English.	Apr 6 2018, 9:00 AM	★	★
Diff 3	838	16617	rINP16618	Apr 6 2018, 9:09 AM	★	★