Unexpected output: Affected paths: relative - resubmit patch.
⚙ D334 INP-1735 - Normalize block parameter values, used during function name creation
Page MenuHomeIn-Portal Phabricator

INP-1735 - Normalize block parameter values, used during function name creation
ClosedPublic

Authored by alex on Mar 30 2018, 7:47 AM.

Details

Test Plan

Preparations

In IDE:

  1. open /themes/advanced/platform/elements/forms.elm.tpl template for editing
  2. for declaration of inp_edit_box block
    1. add default design_name parameter with form_row as value
    2. replace hardcoded form_row occurence with $design_name
  3. save changes

Part 1

  1. on Front-End:
    1. open homepage of advanced theme
    2. click on Register link in login sidebox
    3. confirm, that page opens without any issues
  2. in IDE:
    1. open /themes/advanced/platform/login/register.tpl template for editing
      1. add <inp2:m_DefineElement name="form_row2">AA<inp2:m_Param name="content"/>BB</inp2:m_DefineElement> on top of the template (right after meta comment)
      2. in the 1st usage of inp_edit_box block in the template add design_name="form_row2" parameter
    2. save changes
  3. on Front-End:
    1. reload the page in the browser
    2. confirm, that look of 1st form element has changed, but other similar elements remained unchanged

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 829
Build 829: arc lint + arc unit

Event Timeline

alex created this revision.Mar 30 2018, 7:47 AM
alex added a project: Restricted Project.Mar 30 2018, 7:50 AM
erik accepted this revision.Apr 2 2018, 5:18 AM
This revision is now accepted and ready to land.Apr 2 2018, 5:18 AM
This revision was automatically updated to reflect the committed changes.