Unexpected output:

Affected paths: relative - resubmit patch.

⚙ D338 INP-1739 - Cache results of "\fckFCKHelper::getStyles" method

Differential D338

INP-1739 - Cache results of "\fckFCKHelper::getStyles" method
ClosedPublic
Actions

Authored by alex on Apr 18 2018, 6:12 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rINP16682: Fixes INP-1739 - Cache results of "\fckFCKHelper::getStyles" method

Test Plan

Part 1

Repeat test plan of D251.

Part 2

in IDE:
1. open /system/debug.php for editing
2. uncomment DBG_CURL constant definition and save changes
3. open /themes/advanced/index.tpl template for editing
4. change <inp2:st_ContentBlock num="1"/> into <inp2:st_ContentBlock num="1" mode="inline"/><inp2:st_ContentBlock num="2" mode="inline"/> and save changes
in Admin Console:
1. go to Website & Content → Browse Website section
2. click on Content Mode button in top frame
3. if you get SQL error about ResponseHttpCode column in CurlLog table, then fix that table declaration by setting a default value for that column and repeating previous step
4. confirm, that CURL request for getting styles was made only once

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 868
Build 868: arc lint + arc unit

Event Timeline

alex created this revision.Apr 18 2018, 6:12 AM

Herald added a reviewer: erik. · View Herald TranscriptApr 18 2018, 6:12 AM

alex added a parent revision: D251: INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.Apr 18 2018, 6:12 AM

erik accepted this revision.Apr 25 2018, 6:08 AM

This revision is now accepted and ready to land.Apr 25 2018, 6:08 AM

Closed by commit rINP16682: Fixes INP-1739 - Cache results of "\fckFCKHelper::getStyles" method (authored by alex, committed by ). · Explain WhyMar 15 2021, 3:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 848

core/units/helpers/fck_helper.php

Loading...