Unexpected output: Affected paths: relative - resubmit patch.
⚙ D339 INP-1740 - Make CKEditor URL preview respect "SEO URL Ending"
Page MenuHomeIn-Portal Phabricator

INP-1740 - Make CKEditor URL preview respect "SEO URL Ending"
ClosedPublic

Authored by alex on Apr 18 2018, 8:17 AM.

Details

Test Plan

Part 1

  1. login to Admin Console
  2. go to ConfigurationWebsiteAdvanced section
  3. enable Enable SEO-friendly URLs mode (MOD-REWRITE) setting
  4. set Default URL Ending in SEO-friendly mode setting to an empty value
  5. save changes
  6. go to Website & ContentBrowse Website section
  7. click on Content Mode button in top frame
  8. click on orange Edit Content button
  9. confirm, that CKEditor opens
  10. click on Link toolbar button in CKEditor toolbar
  11. expand Internal Page Name dropdown
  12. confirm, that:
    • URL ending for all page URLs in parenthesis match selected before (except for homepage of course)
    • URL of each page starts with /
  13. repeat test, but with next available value of Enable SEO-friendly URLs mode (MOD-REWRITE) setting until all 3 values are tested

Part 2

  1. login to Admin Console
  2. go to ConfigurationWebsiteAdvanced section
  3. disable Enable SEO-friendly URLs mode (MOD-REWRITE) setting
  4. save changes
  5. go to Website & ContentBrowse Website section
  6. click on Content Mode button in top frame
  7. click on orange Edit Content button
  8. confirm, that CKEditor opens
  9. click on Link toolbar button in CKEditor toolbar
  10. expand Internal Page Name dropdown
  11. confirm that for every page URL in parenthesis looks line non-mod-rewrite url-escaped one

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Class itself is indented incorrectly. Unable to fix.
SeverityLocationCodeMessage
Errorcore/units/fck/fck_eh.php:95PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/fck/fck_eh.php:97PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/fck/fck_eh.php:101PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errorcore/units/fck/fck_eh.php:114PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Unit
No Unit Test Coverage
Build Status
Buildable 869
Build 869: arc lint + arc unit

Event Timeline

alex created this revision.Apr 18 2018, 8:17 AM
alex added a project: Restricted Project.Apr 18 2018, 8:17 AM
erik accepted this revision.Apr 19 2018, 6:02 AM
This revision is now accepted and ready to land.Apr 19 2018, 6:02 AM
This revision was landed with ongoing or failed builds.Mar 15 2021, 3:25 AM
This revision was automatically updated to reflect the committed changes.