Unexpected output: Affected paths: relative - resubmit patch.
⚙ D352 INP-1752 - Update sub-class method signatures to match overridden methods in parent class
Page MenuHomeIn-Portal Phabricator
Differential D352

INP-1752 - Update sub-class method signatures to match overridden methods in parent class
ClosedPublic
Actions

Authored by alex on Oct 30 2018, 11:04 AM.

Details

Reviewers
erik
Commits
rMINC16673: Bug INP-1752 - Update sub-class method signatures to match overridden methods…
rINP16672: Fixes INP-1752 - Update sub-class method signatures to match overridden methods…
Test Plan
  1. open changed files in IDE
  2. for each file confirm, that changed method signatures in sub-classes (classes in changed files) actually match same method signature in their parent class

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing any CS issues, because they're not coming from changed code.
SeverityLocationCodeMessage
Errorcore/units/images/images.php:26PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errorcore/units/images/images.php:26PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingCodingStandard.Commenting.FunctionComment.Missing
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.NotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.NotCamelCaps
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefaultSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefault
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefaultSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefault
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefaultSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefault
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEqualsSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEqualsSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEqualsSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals
Errorcore/units/pdf/pdf_text.php:233PHPCS.E.Squiz.Scope.MethodScope.MissingSquiz.Scope.MethodScope.Missing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.NotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.NotCamelCaps
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefaultSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefault
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEqualsSquiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:27PHPCS.E.Squiz.Scope.MethodScope.MissingSquiz.Scope.MethodScope.Missing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.CodingStandard.Commenting.FunctionComment.ScalarTypeHintMissingCodingStandard.Commenting.FunctionComment.ScalarTypeHintMissing
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.NotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.NotCamelCaps
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errormodules/in-commerce/units/product_option_combinations/product_option_formatters.php:89PHPCS.E.Squiz.Scope.MethodScope.MissingSquiz.Scope.MethodScope.Missing
Unit
No Unit Test Coverage
Build Status
Buildable 896
Build 896: arc lint + arc unit

Event Timeline

alex created this revision.Oct 30 2018, 11:04 AM
alex added a project: Restricted Project.Oct 30 2018, 11:04 AM
erik accepted this revision.Oct 31 2018, 5:53 AM
This revision is now accepted and ready to land.Oct 31 2018, 5:53 AM
This revision was landed with ongoing or failed builds.Mar 12 2021, 10:22 AM
Closed by commit rINP16672: Fixes INP-1752 - Update sub-class method signatures to match overridden methods… (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 187616632Oct 30 2018, 11:04 AM
★
★
Diff 299216671rINP16672Mar 12 2021, 10:22 AM
★
★

Diff 876

View Options

core/units/images/images.php

Loading...
View Options

core/units/pdf/pdf_text.php

Loading...
View Options

modules/in-commerce/units/product_option_combinations/product_option_formatters.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server