Differential D379

INP-1781 - Respect sub-item status, when performing unique validation
ClosedPublic
Actions

Authored by alex on Feb 19 2020, 11:09 AM.

Details

Reviewers

erik

Commits

rINP16756: Fixes INP-1781 - Respect sub-item status, when performing unique validation

Test Plan

in IDE:
- open modules/in-bulletin/units/poll_answers/poll_answers_config.php file for editing
- add 'unique' => array('PollId'), to Answer field declaration
- save changes
- open modules/in-bulletin/units/polls/polls_config.php file for editing
- add 'unique' => array(), to Name field declaration
- save changes
in Admin Console:
- go to Website & Content → Polls section
- create 3 polls with 2 answers in each of them (answer text must be unique within same poll)
- open 2 polls for editing
- delete any answer in any of edited polls, but remember answer text (that is unique)
- attempt to create new answer with that (remembered) text
- confirm, that record is created
- create another poll with name matching existing poll
- confirm, that validation error will be triggered

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 952
Build 952: arc lint + arc unit

Event Timeline

alex created this revision.Feb 19 2020, 11:09 AM

Herald added a reviewer: erik. · View Herald TranscriptFeb 19 2020, 11:09 AM

alex requested review of this revision.Feb 19 2020, 11:09 AM

Harbormaster completed remote builds in B950: Diff 927.Feb 19 2020, 11:09 AM

alex edited the test plan for this revision. (Show Details)Feb 19 2020, 11:11 AM

alex added a project: Restricted Project.

erik accepted this revision.Feb 19 2020, 11:47 AM

This revision is now accepted and ready to land.Feb 19 2020, 11:47 AM

Detected an issue (SQL error), when validation of sub-item happens to before parent item is saved into the database.

Don't perform unique validation from TEMP to LIVE table, when parent record isn't yet created in TEMP table.

This revision is now accepted and ready to land.Mar 18 2020, 4:45 AM

Harbormaster completed remote builds in B952: Diff 929.Mar 18 2020, 4:45 AM

Please test again. Also update test plan to include testing of added code fragment: http://qa.in-portal.org/D379?vs=927&id=929#toc .

erik accepted this revision.Mar 26 2020, 6:12 AM

This revision is now accepted and ready to land.Mar 26 2020, 6:12 AM

Closed by commit rINP16756: Fixes INP-1781 - Respect sub-item status, when performing unique validation (authored by alex, committed by ). · Explain WhyNov 13 2023, 2:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/utility/validator.php (66 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	927	16637		Feb 19 2020, 11:09 AM	★	★
Diff 2	929	16637	Don't perform unique validation from TEMP to LIVE table, when parent record…	Mar 18 2020, 4:45 AM	★	★
Diff 3	1157	16755	rINP16756	Nov 13 2023, 2:35 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 929

View Options

core/kernel/utility/validator.php

INP-1781 - Respect sub-item status, when performing unique validationClosedPublicActions