Unexpected output: Affected paths: relative - resubmit patch.
⚙ D384 INP-1786 - Don't use "continue" inside a "switch" statement
Page MenuHomeIn-Portal Phabricator
Differential D384

INP-1786 - Don't use "continue" inside a "switch" statement
ClosedPublic
Actions

Authored by alex on Jun 10 2020, 8:14 AM.

Details

Reviewers
erik
Commits
rINP16638: Fixes INP-1786 - Don't use "continue" inside a "switch" statement
Test Plan
  1. open Front-End using PHP 7.3 (or above)
  2. confirm, that visiting Front-End isn't causing any warnings to be shown (or logged into System Log)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 957
Build 957: arc lint + arc unit

Event Timeline

alex created this revision.Jun 10 2020, 8:14 AM
alex requested review of this revision.Jun 10 2020, 8:14 AM
alex added a project: Restricted Project.Jun 10 2020, 8:14 AM
erik added a comment.Aug 17 2020, 1:02 PM

Can't test - have PHP 7.2.19 only

erik accepted this revision.Aug 27 2020, 5:31 AM
This revision is now accepted and ready to land.Aug 27 2020, 5:31 AM
Closed by commit rINP16638: Fixes INP-1786 - Don't use "continue" inside a "switch" statement (authored by alex, committed by ). · Explain WhyDec 10 2020, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 193416637Jun 10 2020, 8:14 AM
★
★
Diff 294116637rINP16638Dec 10 2020, 8:33 AM
★
★

Diff 934

View Options

core/kernel/db/db_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server