Unexpected output: Affected paths: no mapping - resubmit patch.
⚙ D401 INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units
Page MenuHomeIn-Portal Phabricator
Differential D401

INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units
ClosedPublic
Actions

Authored by alex on Mar 16 2021, 9:14 AM.

Details

Reviewers
erik
Commits
rMINL16719: Fixes INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of…
rMINC16720: Bug INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog…
rMINC16721: Bug INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog…
Test Plan

Part 1 (export)

  1. login to Admin Console
  2. go to Website & Content → Structure & Data section
  3. in corresponding module root categories (Directory, News, Products) create some records (link, article, product)
  4. perform an export of each item type via Tools > Export menu
  5. confirm, that fields in exported CSV file are divided by "," (comma) and not ", " (comma with a trailing space)
  6. confirm, that exporting hasn't caused any errors logged in System Log section
  7. go to E-commerce → Orders section
  8. create some orders
  9. perform an export of each item type via Export button on Search tab
  10. confirm, that fields in exported CSV file are divided by "," (comma) and not ", " (comma with a trailing space)
  11. confirm, that exporting hasn't caused any errors logged in System Log section

Part 2 (import)

  1. login to Admin Console
  2. go to Tools → Import Data section
  3. try importing back CSV files generated in the previous test plan part (e.g. links.csv, articles.csv, products.csv)
  4. on the next import wizard screen confirm, that Fields separated by field value doesn't contain a trailing space
  5. confirm, that importing hasn't caused any errors logged in System Log section

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Only fixing issues introduced by code changing
SeverityLocationCodeMessage
Errormodules/in-commerce/units/orders/orders_config.php:523PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/orders/orders_config.php:523PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/orders/orders_config.php:524PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/orders/orders_config.php:524PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/orders/orders_config.php:525PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/orders/orders_config.php:525PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:586PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:586PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:587PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:587PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:588PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:588PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-link/units/links/links_config.php:524PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-link/units/links/links_config.php:524PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-link/units/links/links_config.php:525PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-link/units/links/links_config.php:525PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-link/units/links/links_config.php:526PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-link/units/links/links_config.php:526PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 1035
Build 1035: arc lint + arc unit

Event Timeline

alex created this revision.Mar 16 2021, 9:14 AM
alex requested review of this revision.Mar 16 2021, 9:14 AM
alex edited the test plan for this revision. (Show Details)Mar 16 2021, 9:22 AM
alex added a project: Restricted Project.
erik requested changes to this revision.Mar 17 2021, 6:04 AM

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
This revision now requires changes to proceed.Mar 17 2021, 6:04 AM
alex requested review of this revision.Jul 20 2022, 2:46 AM
In D401#7949, @erik wrote:

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt

Thanks for finding this. I've created D421 with a fix to this issue because it isn't caused by changes in this differential revision.

You can accept this revision now.

erik accepted this revision.Jul 20 2022, 5:10 AM
This revision is now accepted and ready to land.Jul 20 2022, 5:10 AM
This revision was landed with ongoing or failed builds.Jul 20 2022, 6:21 AM
Closed by commit rMINL16719: Fixes INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of… (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1100716685Mar 16 2021, 9:14 AM
★
★
Diff 2106916694rMINL16719Jul 20 2022, 6:21 AM
★
★

Diff 1007

View Options

modules/in-commerce/units/orders/orders_config.php

Loading...
View Options

modules/in-commerce/units/products/products_config.php

Loading...
View Options

modules/in-link/units/links/links_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server