Unexpected output: Affected paths: relative - resubmit patch.
⚙ D412 INP-1808 - Create "E-mail Log" records using corresponding unit
Page MenuHomeIn-Portal Phabricator
Differential D412

INP-1808 - Create "E-mail Log" records using corresponding unit
ClosedPublic
Actions

Authored by alex on Jul 1 2021, 11:49 AM.

Details

Reviewers
erik
Commits
rINP16699: Fixes INP-1808 - Create "E-mail Log" records using corresponding unit
Test Plan
  1. login to the Admin Console
  2. remove all records from Logs & Reports → E-mail Log and User Management → Mailings → Email Queue (tab)
  3. go to User Management → Users section
  4. create a record if none present
  5. try disabling any enabled record (or enabled any disabled record if all records are disabled)
  6. go to User Management → Mailings → Email Queue (tab) section
  7. confirm, that a queue record was added into it
  8. press Process Queue toolbar button
  9. confirmed that queued record went away
  10. go to Logs & Reports → E-mail Log section
  11. confirm, that e-mail record was created as part of queued record processing

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Not fixing issues introduced before these changes.
SeverityLocationCodeMessage
Errorcore/units/logs/email_logs/email_logs_config.php:92PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/email_logs/email_logs_config.php:92PHPCS.E.Generic.PHP.LowerCaseConstant.FoundGeneric.PHP.LowerCaseConstant.Found
Errorcore/units/logs/email_logs/email_logs_config.php:92PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/logs/email_logs/email_logs_config.php:93PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/logs/email_logs/email_logs_config.php:93PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 1048
Build 1048: arc lint + arc unit

Event Timeline

alex created this revision.Jul 1 2021, 11:49 AM
alex requested review of this revision.Jul 1 2021, 11:49 AM
alex updated this revision to Diff 1021.Jul 1 2021, 12:01 PM

Remove temporary object used for e-mail log record creation to avoid memory leaks.

erik accepted this revision.Aug 6 2021, 9:19 AM
This revision is now accepted and ready to land.Aug 6 2021, 9:19 AM
alex retitled this revision from INP-1808 - Create "E-mail Log" records unit corresponding unit to INP-1808 - Create "E-mail Log" records using corresponding unit.Jul 8 2022, 7:56 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 7:59 AM
Closed by commit rINP16699: Fixes INP-1808 - Create "E-mail Log" records using corresponding unit (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1102016691Jul 1 2021, 11:49 AM
★
★
Diff 2102116691Remove temporary object used for e-mail log record creation to avoid memory…Jul 1 2021, 12:01 PM
★
★
Diff 3104716698rINP16699Jul 8 2022, 7:59 AM
★
★

Diff 1020

View Options

core/kernel/utility/email_send.php

Loading...
View Options

core/units/logs/email_logs/email_logs_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server