Differential D419

INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method
ClosedPublic
Actions

Authored by alex on Jun 2 2022, 8:55 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16716: Fixes INP-1816 - Use argument-based cache in the "kApplication…

Test Plan

in Admin Console
- perform logout if you're logged-in

in IDE:
- open /system/debug.php file for editing
- comment-out 'DEBUG_MODE' key in the $dbg_options array
- save changes
- open /admin/index.php file for editing
- replace $application->Run(); line with this code:

echo 'T1: [' . $application->GetDefaultThemeId() . ']<br/>';
echo 'T2: [' . $application->GetDefaultThemeId(true) . ']<br/>';
echo 'T3: [' . $application->GetDefaultThemeId() . ']<br/>';
echo 'T4: [' . $application->GetDefaultThemeId(true) . ']<br/>';

save changes

in Admin Console
- open login screen
- confirm, that out contains:

T1: [999]
T2: [1]
T3: [999]
T4: [1]

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jun 2 2022, 8:55 AM

Herald added a reviewer: erik. · View Herald TranscriptJun 2 2022, 8:55 AM

alex requested review of this revision.Jun 2 2022, 8:55 AM

Harbormaster completed remote builds in B1068: Diff 1038.Jun 2 2022, 8:55 AM

alex edited the test plan for this revision. (Show Details)Jun 2 2022, 8:57 AM

alex added a project: Restricted Project.

alex edited the test plan for this revision. (Show Details)

erik accepted this revision.Jul 14 2022, 9:19 AM

This revision is now accepted and ready to land.Jul 14 2022, 9:19 AM

Closed by commit rINP16716: Fixes INP-1816 - Use argument-based cache in the "kApplication… (authored by alex, committed by ). · Explain WhyJul 19 2022, 6:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1064

branches/5.2.x/core/kernel/application.php

Loading...