Unexpected output: Affected paths: relative - resubmit patch.
⚙ D419 INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method
Page MenuHomeIn-Portal Phabricator

INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method
ClosedPublic

Authored by alex on Jun 2 2022, 8:55 AM.

Details

Test Plan
  1. in Admin Console
    • perform logout if you're logged-in
  1. in IDE:
    • open /system/debug.php file for editing
    • comment-out 'DEBUG_MODE' key in the $dbg_options array
    • save changes
    • open /admin/index.php file for editing
    • replace $application->Run(); line with this code:
echo 'T1: [' . $application->GetDefaultThemeId() . ']<br/>';
echo 'T2: [' . $application->GetDefaultThemeId(true) . ']<br/>';
echo 'T3: [' . $application->GetDefaultThemeId() . ']<br/>';
echo 'T4: [' . $application->GetDefaultThemeId(true) . ']<br/>';
  • save changes
  1. in Admin Console
    • open login screen
    • confirm, that out contains:
T1: [999]
T2: [1]
T3: [999]
T4: [1]

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1068
Build 1068: arc lint + arc unit

Event Timeline

alex created this revision.Jun 2 2022, 8:55 AM
alex requested review of this revision.Jun 2 2022, 8:55 AM
alex edited the test plan for this revision. (Show Details)Jun 2 2022, 8:57 AM
alex added a project: Restricted Project.
alex edited the test plan for this revision. (Show Details)
erik accepted this revision.Jul 14 2022, 9:19 AM
This revision is now accepted and ready to land.Jul 14 2022, 9:19 AM
This revision was automatically updated to reflect the committed changes.