Page MenuHomeIn-Portal Phabricator

INP-1834 - Connect "mtdowling/cron-expression" library
ClosedPublic

Authored by alex on Nov 8 2022, 9:52 AM.

Details

Test Plan

Preparations

  1. login to the Admin Console
  2. go to ConfigurationWebsiteScheduled Tasks

Testing validation

  1. test Minute field validation:
    1. open any scheduled task for editing
    2. put values 0, 1, 47, 2-7, */5, and 59 into a Minute field
    3. save changes
    4. confirm, that no validation error happened
    5. put values 60, and 75 into a Minute field
    6. save changes
    7. confirm, that the validation error happened
  1. test Hour field validation:
    1. open any scheduled task for editing
    2. put values 0, 7, 4-15, */5, and 23 into an Hour field
    3. save changes
    4. confirm, that no validation error happened
    5. put values 60, and 75 into an Hour field
    6. save changes
    7. confirm, that the validation error happened
  1. test Day field validation:
    1. open any scheduled task for editing
    2. put values 1, 12, 3-8, */2, and 30 into a Day field
    3. save changes
    4. confirm, that no validation error happened
    5. put values 60, and 75 into a Day field
    6. save changes
    7. confirm, that the validation error happened
  1. test Month field validation:
    1. open any scheduled task for editing
    2. put values 1, FEB, 5-7, */2, and 12 into a Month field
    3. save changes
    4. confirm, that no validation error happened
    5. put values 60, and 75 into a Month field
    6. save changes
    7. confirm, that the validation error happened
  1. test Weekday field validation:
    1. open any scheduled task for editing
    2. put values 3, FRI, 2-5, */2, and 6 into a Weekday field
    3. save changes
    4. confirm, that no validation error happened
    5. put values 60, and 75 into a Weekday field
    6. save changes
    7. confirm, that the validation error happened

Testing next run date

  1. open any scheduled task for editing
  2. clear the Next Run On field
  3. set cron expression from the below list (try each one):
    1. once a minute
    2. once an hour
    3. once a day
    4. once a month
    5. once a week
  4. save changes
  5. open changed record for editing
  6. confirm, that Next Run On was calculated correctly

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Nov 8 2022, 9:52 AM
alex requested review of this revision.Nov 8 2022, 9:52 AM
alex added a project: Restricted Project.Nov 8 2022, 9:53 AM
alex edited the test plan for this revision. (Show Details)Nov 8 2022, 10:50 AM
erik requested changes to this revision.Nov 8 2022, 11:30 AM

Found difference from test plan expectation:
test Hour field validation: has error on 30-35 value

This revision now requires changes to proceed.Nov 8 2022, 11:30 AM
alex requested review of this revision.Nov 8 2022, 12:42 PM
alex edited the test plan for this revision. (Show Details)

The test plan contained an error. Please retest from that place.

erik accepted this revision.Nov 8 2022, 12:51 PM
This revision is now accepted and ready to land.Nov 8 2022, 12:51 PM
This revision was automatically updated to reflect the committed changes.