Page MenuHomeIn-Portal Phabricator

INP-1847 - Specify image resizing defaults for category item images
ClosedPublic

Authored by alex on Jan 2 2024, 4:13 AM.

Details

Test Plan
  1. in Admin Console
    1. go to the Website & ContentStructure & DataProducts section
    2. add some sub-categories (without images) to it
    3. add some products (without images) to these categories
  2. on the Front-End
    1. open any of above created categories with products
    2. confirm, that page contains no notices, except these:
      1. Usage of undefined configuration variable "c_ThumbnailImageWidth"...
      2. Declaration of SpamHelper::InitHelper() should be compatible with kHelper::InitHelper()...
    3. confirm, that product image URL ends with /themes/advanced/platform/img/no_picture.gif
  3. in IDE:
    1. open themes/advanced/in-commerce/elements/products.elm.tpl file for editing
    2. replace platform/img/no_picture.gif in the product_element block with platform/img/google_map_sample.gif
    3. save changes
  4. on the Front-End
    1. reload the page with product list
    2. confirm, that page contains no notices, except these:
      1. Usage of undefined configuration variable "c_ThumbnailImageWidth"...
      2. Declaration of SpamHelper::InitHelper() should be compatible with kHelper::InitHelper()...
    3. confirm, that product image URL ends with /system/thumbs/themes/advanced/platform/img/google_map_sample_{N}.gif (there will be some number instead of {N})

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jan 2 2024, 4:13 AM
alex requested review of this revision.Jan 2 2024, 4:13 AM
erik accepted this revision.Jan 2 2024, 5:02 AM

Test plan works well also without applying this patch.

This revision is now accepted and ready to land.Jan 2 2024, 5:02 AM
erik added a comment.Jan 2 2024, 5:33 AM

After in-portal update, test plan works well only after patch applying.

This revision was automatically updated to reflect the committed changes.