Differential D456

INP-1850 - Repair the "kHTTPQuery::getHeaders" method
ClosedPublic
Actions

Authored by alex on Jan 9 2024, 3:55 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16782: Fixes INP-1850 - Repair the "kHTTPQuery::getHeaders" method

Test Plan

in IDE:
1. open the /index.php file for editing
2. replace the $application->Run(); line with the echo '<pre>', print_r($application->HttpQuery->getHeaders(), true), '</pre>'; line
3. save changes
on the Front-End
1. open website
2. confirm, that displayed array:
  1. contains more than one element
  2. doesn't contain element with Http- key
  3. look similar to the array from the associated Confluence discussion

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jan 9 2024, 3:55 AM

Herald added a reviewer: erik. · View Herald TranscriptJan 9 2024, 3:55 AM

alex requested review of this revision.Jan 9 2024, 3:55 AM

Harbormaster completed remote builds in B1229: Diff 1185.Jan 9 2024, 3:55 AM

alex added a project: Restricted Project.Jan 9 2024, 3:56 AM

Can't test - local system has apache_request_headers function and test array looks good without patch.

In D456#9259, @erik wrote:

Can't test - local system has apache_request_headers function and test array looks good without patch.

@erik, please comment-out usage of the “apache_request_headers” function in the changed method and continue testing.

erik accepted this revision.Jan 11 2024, 4:07 AM

This revision is now accepted and ready to land.Jan 11 2024, 4:07 AM

Closed by commit rINP16782: Fixes INP-1850 - Repair the "kHTTPQuery::getHeaders" method (authored by alex, committed by ). · Explain WhyJan 15 2024, 3:32 AM

This revision was automatically updated to reflect the committed changes.

alex mentioned this in D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.Jan 24 2024, 6:21 AM

Revision Contents
Changeset List

Diff 1186

branches/5.2.x/core/kernel/utility/http_query.php

Loading...