Unexpected output: Affected paths: relative - resubmit patch.
⚙ D461 INP-1855 - Support for window scrolling offset in the "Form" JS class
Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/admin_templates/js/forms.js

INP-1855 - Support for window scrolling offset in the "Form" JS class
AcceptedPublic

Authored by alex on Jan 17 2024, 10:05 AM.

Details

Reviewers
erik
Test Plan
  • in the IDE:
    1. add the following code in the \ConfigurationEventHandler::OnBeforeItemValidate method (file: core/units/configuration/configuration_event_handler.php) after an $object variable was initialized:
if ( $object->GetDBField('VariableName') === 'SoftMaintenanceTemplate' ) {
    $object->SetError('VariableValue', 'required');
}
  • in the Admin Console:
    1. go to the ConfigurationWebsiteAdvanced section
    2. press the Save toolbar button
    3. confirm, that the page automatically scrolls to the Template for Soft Maintenance system setting
    4. confirm, that error is displayed after the Template for Soft Maintenance system setting

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1235
Build 1235: arc lint + arc unit

Event Timeline

alex created this revision.Jan 17 2024, 10:05 AM
alex requested review of this revision.Jan 17 2024, 10:05 AM
alex added a project: Restricted Project.Jan 17 2024, 10:05 AM
erik accepted this revision.Jan 22 2024, 10:33 AM
This revision is now accepted and ready to land.Jan 22 2024, 10:33 AM