Page MenuHomeIn-Portal Phabricator

INP-1857 - Prevent recursion in the "\kUrlManager::show404" method
AcceptedPublic

Authored by alex on Jan 22 2024, 4:48 AM.

Details

Reviewers
erik
Test Plan

Preparations (in IDE)

  1. open the themes/advanced/error_notfound.tpl file for editing
  2. add below shown code after <inp2:m_phrase name="lu_text_PageNotFound"/> tag:
<inp2:m_DefineElement name="product_element">
    [<inp2:Field name="SKU"/>]
</inp2:m_DefineElement>
<inp2:p_PrintList render_as="product_element"/>
  1. save changes
  2. open the themes/advanced/platform/my_account/my_account.tpl file for editing
  3. add below shown code after the topmost HTML comment on the template:
<?php
    $application =& kApplication::Instance();
    $application->UrlManager->show404();
?>
  1. save changes

Actual testing

  1. go to the Front-End
  2. confirm, that you're setting an expected page
  3. open /missing/500/ page (manually append to base URL of the website)
  4. confirm, that Page Not Found page was shown
  5. click on the My Account link in the header
  6. confirm, that Page Not Found page was shown
  7. click on the Register link in the sidebar
  8. confirm, that you're setting an expected page

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1236
Build 1236: arc lint + arc unit

Event Timeline

alex created this revision.Jan 22 2024, 4:48 AM
alex requested review of this revision.Jan 22 2024, 4:48 AM
alex added a project: Restricted Project.Jan 22 2024, 4:48 AM
alex edited the test plan for this revision. (Show Details)
erik accepted this revision.Jan 22 2024, 10:23 AM
This revision is now accepted and ready to land.Jan 22 2024, 10:23 AM