Unexpected output: Affected paths: relative - resubmit patch.
⚙ D464 INP-1859 - Escape MySQL 8.3 keywords
Page MenuHomeIn-Portal Phabricator
Differential D464

INP-1859 - Escape MySQL 8.3 keywords
ClosedPublic
Actions

Authored by alex on Jan 23 2024, 5:27 AM.

Details

Reviewers
erik
Commits
rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords
rMINC16787: Bug INP-1859 - Escape MySQL 8.3 keywords
Test Plan
NOTE: You must use MySQL 8.x (or equivalent in other MySQL forks) to verify, that a fix is working
  1. perform a clean install
  2. confirm, that no SQL error, that blocks the installation process, happened
  3. login to Admin Console
  4. go to the Website & Content → Structure & Data → Products section
  5. click on the Products tab
  6. confirm, that no SQL error has happened
  7. create a product
  8. confirm, that no SQL error has happened

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Haven't introduced any of these
SeverityLocationCodeMessage
Errormodules/in-commerce/units/products/products_config.php:549PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:549PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:549PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:549PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.Generic.PHP.LowerCaseConstant.FoundGeneric.PHP.LowerCaseConstant.Found
Errormodules/in-commerce/units/products/products_config.php:550PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/products/products_config.php:551PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/products/products_config.php:551PHPCS.E.Generic.PHP.LowerCaseConstant.FoundGeneric.PHP.LowerCaseConstant.Found
Errormodules/in-commerce/units/products/products_config.php:551PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 1239
Build 1239: arc lint + arc unit

Event Timeline

alex created this revision.Jan 23 2024, 5:27 AM
alex requested review of this revision.Jan 23 2024, 5:27 AM
alex retitled this revision from MINC-201 - Escape MySQL 8.3 keywords to INP-1859 - Escape MySQL 8.3 keywords.Jan 23 2024, 7:28 AM
alex updated JIRA issue(s): added 1 INP-1859; removed 1 MINC-201.
alex updated this revision to Diff 1195.Jan 23 2024, 7:30 AM

Handle an SQL error during the Clean Install.

alex edited the test plan for this revision. (Show Details)Jan 23 2024, 7:31 AM
erik accepted this revision.Jan 24 2024, 5:01 AM

Can't test with correct MySQL version, but visually code looks good and works good with current MySQL version.

This revision is now accepted and ready to land.Jan 24 2024, 5:01 AM
alex added a project: Restricted Project.Jan 24 2024, 10:54 AM
This revision was landed with ongoing or failed builds.Jun 17 2024, 9:53 AM
Closed by commit rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1119416780Jan 23 2024, 5:27 AM
★
★
Diff 2119516780Handle an SQL error during the Clean Install.Jan 23 2024, 7:30 AM
★
★
Diff 3121316785rINP16786Jun 17 2024, 9:53 AM
★
★

Diff 1195

View Options

core/install/install_schema.sql

Loading...
View Options

modules/in-commerce/units/products/products_config.php

Loading...
View Options

modules/in-commerce/units/products/products_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server