Unexpected output: Affected paths: relative - resubmit patch.
⚙ D467 INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place
Page MenuHomeIn-Portal Phabricator

INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place
AcceptedPublic

Authored by alex on May 9 2024, 8:18 AM.

Details

Reviewers
erik
Test Plan

Preparation

  1. login to the Admin Console
  2. go to the ConfigurationWebsiteGeneral section
  3. set the value of the "Website name" system setting to the one"<strong>two</strong> three
  4. save changes

Part 1 - header and frameset

  1. login to the Admin Console
  2. go to the ConfigurationWebsiteGeneral section
  3. reload the page using Web Browser functionality (e.g. Reload current page toolbar button or Cmd+R/Ctrl+R shortcut)
  4. confirm, that while page reloading isn't finished page title (on the Web Browser tab) was changed to one"two three - Administrative Console
  5. confirm, that after page reloading is finished page title (on the Web Browser tab) was changed to General - Administrative Console - one"two three

Part 2 - login screen

  1. go to the Admin Console
  2. if logged-in, then perform a logout
  3. confirm, that an alt attribute of the image above the login form has one&quot;two three value (look at "View Source" instead of inspecting an element)
  4. in database:
    • go to the primary skin record in the AdminSkins table
    • remeber value in the LogoLogin column (mine was in-portal_logo_login.gif)
    • clear value in the LogoLogin column
  5. reset memory cache + reload the page in the Web Browser
  6. confirm, that the design of the login page was changed
  7. confirm, that an alt attribute of the both images above the login form has one&quot;two three value

Part 3 - the "advanced" theme

  1. open the .../advanced/in-news/elements/rss.xml URL (replace ... with path to your In-Portal installation)
  2. confirm, that rsschanneltitle and rsschannelgenerator XML nodes have one&quot;two three value
  3. open the .../advanced/index.html URL
  4. confirm, that page title (on the Web Browser tab) is one"two three :: Welcome to In-Portal!
  5. confirm, that an alt attribute of the both images in the top left corner (globe icon & In-Portal logo) has one&quot;two three value
  6. create the /themes/advanced/test_popup.tpl file with the following content:
<!--##
<NAME>Test Popup</NAME>
<DESC>Test Popup</DESC>
<SECTION></SECTION>
##-->

<!--## PAGE TITLE ELEMENT ##-->
<inp2:m_DefineElement name="page_title">
  Test Popup Title
</inp2:m_DefineElement>
<!--## //PAGE TITLE ELEMENT ##-->

<inp2:m_DefineElement name="content">
  test popup content
</inp2:m_DefineElement>

<inp2:m_include template="platform/designs/popup_design.des" pass_params="1"/>
  1. in another tab use Rescan Themes toolbar button in the Themes section of the admin console
  2. open the .../advanced/test-popup.html URL
  3. confirm, that page title (on the Web Browser tab) is one"two three

Part 4 - the "default" theme

  1. open the .../default/index.html URL
  2. confirm, that page title (on the Web Browser tab) is (one"two three)
  3. confirm, that page source contains <meta name="author" content="one&quot;two three"/>

Part 5 - the "simple" theme

  1. open the .../simple/index.html URL
  2. confirm, that page title (on the Web Browser tab) is (one"two three)
  3. confirm, that page source contains <meta name="author" content="one&quot;two three"/>
  4. line removed
  5. confirm, that an title attribute of the invisible link in the top left corner (on red background) has one&quot;two three value

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1245
Build 1245: arc lint + arc unit

Event Timeline

alex created this revision.May 9 2024, 8:18 AM
alex requested review of this revision.May 9 2024, 8:18 AM
alex edited the test plan for this revision. (Show Details)May 9 2024, 8:20 AM
alex updated this revision to Diff 1201.May 9 2024, 9:25 AM

Removed debug code.

erik requested changes to this revision.May 30 2024, 12:06 PM

All right in general, but

2.6 confirm, that the design of the login page was changed - changed, but only after memcache reset
5.4 - incomplete or excessive line in test plan
5.5 confirm, that an alt attribute of the invisible link in the top left corner (on red background) has one&quot;two three value - there is such title attribute, no alt attribute

This revision now requires changes to proceed.May 30 2024, 12:06 PM
alex edited the test plan for this revision. (Show Details)Jun 3 2024, 10:57 AM
alex requested review of this revision.Jun 3 2024, 10:59 AM
alex edited the test plan for this revision. (Show Details)
In D467#9487, @erik wrote:

All right in general, but

2.6 confirm, that the design of the login page was changed - changed, but only after memcache reset
5.4 - incomplete or excessive line in test plan
5.5 confirm, that an alt attribute of the invisible link in the top left corner (on red background) has one&quot;two three value - there is such title attribute, no alt attribute

You're correct in all mentioned cases. Please approve.

erik accepted this revision.Jun 3 2024, 11:15 AM
This revision is now accepted and ready to land.Jun 3 2024, 11:15 AM