Page MenuHomeIn-Portal Phabricator
Differential D480

INP-1872 - Properly handle constant absence during category cache rebuild
ClosedPublic
Actions

Authored by alex on Aug 5 2024, 2:35 AM.

Details

Reviewers
erik
Commits
rINP16814: Fixes INP-1872 - Properly handle constant absence during category cache rebuild
Test Plan
  1. in IDE:
    1. open /system/config.php file
    2. set $_CONFIG['Misc']['EnableSystemLog'] to 1
    3. set $_CONFIG['Misc']['SystemLogMaxLevel'] to 5
    4. save changes
  2. login to Admin Console
  3. go to the Logs & Reports → System Log section
  4. remember last system log record ID
  5. go to the Website & Content → Structure & Data section
  6. click on the Rebuild Section Cache menu item under Tools toolbar button
  7. confirm, that you need to perform the rebuild
  8. go to the Logs & Reports → System Log section
  9. confirm, that no new system log records were added

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Aug 5 2024, 2:35 AM
alex requested review of this revision.Aug 5 2024, 2:35 AM
alex added a project: Restricted Project.Aug 5 2024, 2:35 AM
erik requested changes to this revision.Aug 5 2024, 9:12 AM

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

All errors are

This revision now requires changes to proceed.Aug 5 2024, 9:12 AM
alex added a comment.EditedSat, Oct 26, 9:50 AM
In D480#9710, @erik wrote:

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

All errors are

The issue was addressed in the D493 and D492. Please accept this revision.

alex planned changes to this revision.Sat, Oct 26, 9:51 AM
alex requested review of this revision.
erik accepted this revision.Mon, Oct 28, 5:20 AM

All right, when debugger is off. When debugger os on - got about 20 "Trying to access array offset on value of type bool" notices

Patch have no influence on notice count. Same notices happens and without patch. 4 (four) such notices happens when only "go to the Website & Content → Structure & Data section".

This revision is now accepted and ready to land.Mon, Oct 28, 5:20 AM
Closed by commit rINP16814: Fixes INP-1872 - Properly handle constant absence during category cache rebuild (authored by alex, committed by ). · Explain WhyMon, Oct 28, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1123216796Aug 5 2024, 2:35 AM
★
★
Diff 2126916813rINP16814Mon, Oct 28, 6:26 AM
★
★

Diff 1269

View Options

branches/5.2.x/core/units/categories/cache_updater.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server