Page MenuHomeIn-Portal Phabricator

INP-1885 - Consistently use PHP binary during the Build
Needs ReviewPublic

Authored by alex on Sun, Nov 17, 12:52 PM.

Details

Reviewers
erik
Test Plan
  1. in IDE:
    1. (or in CLI) apply the patch from the D495
    2. remove contents of the core/units/helpers/xml_helper.php and core/units/helpers/xml_helper5.php files
  2. in CLI:
    1. run the phing -f tools/build/build_all.xml -verbose build command
    2. confirm, that:
      • the build was successful
      • these commands were executed during look at the output of the above-executed command (the {php_binary} part represents PHP binary; the ... represent irrelevant command parts):
        • [composer] executing {php_binary} /usr/local/bin/composer install --working-dir ... --ansi
        • [exec] Executing command: {php_binary} .../tools/run_event.php adm:OnDeploy b674006f3edb1d9cd4d838c150b0567d ... 2>&1
        • [exec] Executing command: {php_binary} '-d memory_limit=-1' .../phpcpd --log-pmd=...
      • run the {other_php_binary} phing -f tools/build/build_all.xml -verbose build command (replace {other_php_binary} with any other available PHP version, e.g. php56, php72, php74, etc.
      • confirm, that the specified binary, or in the case of a symlink, the original PHP binary was used in the above-shown commands

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1335
Build 1335: arc lint + arc unit

Event Timeline

alex created this revision.Sun, Nov 17, 12:52 PM
alex requested review of this revision.Sun, Nov 17, 12:52 PM