Page MenuHomeIn-Portal Phabricator
  • Changed Files
  • core/admin_templates/js/uploader/moxie.js

INP-1907 - Permit file uploads in any Web Browser
AcceptedPublic

Authored by alex on Tue, Apr 8, 8:15 AM.

Details

Reviewers
erik
Test Plan

Part 1 (without the patch)

  1. don't apply the patch
  2. go to Admin Console
  3. go to the Website & ContentPolls section
  4. create a new poll, if there are none present
  5. open any poll for editing
  6. inspect (using Web Browser inspector tool) the yellow Browse button for the Image field
  7. confirm, that (good):
    • the Browse button was shown in the inspector and it has z-index value of 1
    • the Plupload-generated DIV below the button has z-index value of 0
  8. switch to the Responsive Design Mode
  9. reload the page (if you'll end up in the polls grid, then open same poll for editing)
  10. inspect (using Web Browser inspector tool) the yellow Browse button for the Image field
  11. confirm, that (bad):
    • the input[type=file] element within the Plupload-generated DIV was shown in the inspector and has no z-index CSS property
    • (updated) the Browse button was shown in the inspector and it has no z-index CSS property
    • the Plupload-generated DIV below the button has no z-index CSS property
  12. exit the Responsive Design Mode

Part 2 (with the patch)

  1. apply the patch
  2. go to Admin Console
  3. go to the Website & ContentPolls section
  4. create a new poll, if there are none present
  5. open any poll for editing
  6. inspect (using Web Browser inspector tool) the yellow Browse button for the Image field
  7. confirm, that (good):
    • the Browse button was shown in the inspector and it has z-index value of 1
    • the Plupload-generated DIV below the button has z-index value of 0
  8. switch to the Responsive Design Mode
  9. reload the page (if you'll end up in the polls grid, then open same poll for editing)
  10. inspect (using Web Browser inspector tool) the yellow Browse button for the Image field
  11. confirm, that (good):
    • the Browse button was shown in the inspector and it has z-index value of 1
    • the Plupload-generated DIV below the button has z-index value of 0
  12. exit the Responsive Design Mode

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11077
Build 3777: arc lint + arc unit

Event Timeline

alex created this revision.Tue, Apr 8, 8:15 AM
alex requested review of this revision.Tue, Apr 8, 8:15 AM
alex updated this revision to Diff 1331.Tue, Apr 8, 8:18 AM

Added reference to the used code origins.

erik accepted this revision.Tue, Apr 8, 9:27 AM

Part 2 - all right, so revision is accepted.

Part 1 results - has differences from test plan.

1.7 - "confirm, that ... the the Plupload-generated DIV below the button has z-index value of 0" - technically yes, but literally - no. Plupload-generated DIV below the button has no z-index value.
1.11 - "confirm, that ... the Browse button was shown in the inspector and it has z-index value of 1" - no. Browse button has no z-index value.

This revision is now accepted and ready to land.Tue, Apr 8, 9:27 AM
alex added a comment.Wed, Apr 9, 3:10 AM
In D518#10573, @erik wrote:

Part 1 results - has differences from test plan.

1.7 - "confirm, that ... the the Plupload-generated DIV below the button has z-index value of 0" - technically yes, but literally - no. Plupload-generated DIV below the button has no z-index value.

Please provide a screenshot.

1.11 - "confirm, that ... the Browse button was shown in the inspector and it has z-index value of 1" - no. Browse button has no z-index value.

You're correct. It's my mistake in the test plan. Both elements (the Browse button and Plupload-generated DIV shoudn't have a z-index. I've updated a test plan.

alex edited the test plan for this revision. (Show Details)Wed, Apr 9, 3:11 AM
erik added a comment.Wed, Apr 9, 6:27 AM

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

alex added a comment.Wed, Apr 9, 6:40 AM
In D518#10578, @erik wrote:

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Thank you. I've also suspected that this could be some web browser glitch.