Differential D523

INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events
ClosedPublic
Actions

Authored by alex on Mon, May 26, 10:33 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for…

Test Plan

Part 1

(new) apply the patch from the D524, unless it's already committed
apply the patch from the D522, unless it's already committed
enable Debug Mode
execute the test plan of the D522

Part 2

disable Debug Mode
on the Front-End:
1. open the /index.php?env=-login%3Am0--1--s-&events[orda]=OnMissing URL
2. confirm, that you'll see a 404 Page Not Found page
3. confirm, that record in the System Log isn't created about this incident
4. open the /index.php?env=-login%3Am0--1--s-&events[ord]=OnMissing URL
5. confirm, that you'll see a 404 Page Not Found page
6. confirm, that record in the System Log isn't created about this incident
in the Admin Console login screen:
1. open the /admin/index.php?env=-login%3Am0--1--s-&events[orda]=OnMissing URL
2. confirm, that a Oops, something went wrong text is shown
3. confirm, that a System Log record with Configuration file for prefix "orda" is unknown text was created
4. open the /admin/index.php?env=-login%3Am0--1--s-&events[ord]=OnMissing URL
5. confirm, that a Oops, something went wrong text is shown
6. confirm, that a System Log record with Event "OnMissing" not implemented in class "OrdersEventHandler" text was created

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Mon, May 26, 10:33 AM

Herald added a reviewer: erik. · View Herald TranscriptMon, May 26, 10:33 AM

alex requested review of this revision.Mon, May 26, 10:33 AM

Harbormaster completed remote builds in B11089: Diff 1343.Mon, May 26, 10:33 AM

alex added a parent revision: D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.Mon, May 26, 10:34 AM

2.2 - this part of test plan is excessive
2.3 - Failed all front-end tests. Always shown Oops, something went wrong text, not 404 page. Always System Log IS created about incident

This revision now requires changes to proceed.Mon, May 26, 11:05 AM

alex edited the test plan for this revision. (Show Details)Mon, May 26, 12:11 PM

2.2 - this part of test plan is excessive

Removed excessive part.

2.3 - Failed all front-end tests. Always shown Oops, something went wrong text, not 404 page. Always System Log IS created about incident

This worked with mod-rewrite turned off, but with mod-rewrite turned on, it failed. I'll look into that.

I've added # (new) apply the patch from the D524, unless it's already committed line, that should fix the problem. Please retest.

erik accepted this revision.Tue, May 27, 5:51 AM

This revision is now accepted and ready to land.Tue, May 27, 5:51 AM

Closed by commit rINP16830: Fixes INP-1912 - Show "404 Page Not Found" page on the Front-End for… (authored by alex, committed by ). · Explain WhyTue, May 27, 8:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1346

branches/5.2.x/core/kernel/managers/request_manager.php

Loading...