Page MenuHomeIn-Portal Phabricator

INP-1916 - Correct scroll-to-error behavior on the Configuration Pages
Needs ReviewPublic

Authored by alex on Sat, Jul 19, 7:04 AM.

Details

Reviewers
erik
Test Plan

Preparations

In IDE:

  1. open the core/units/configuration/configuration_event_handler.php file for editing
  2. add this code at the end of the \ConfigurationEventHandler::OnBeforeItemValidate method:
if ( $object->GetDBField('VariableName') === 'UseColumnFreezer' ) {
    $object->SetError('VariableValue', 'invalid_format');
}
  1. save changes

Part 1

  1. login to the Admin Console
  2. go to the ConfigurationWebsiteAdvanced section
  3. type different values for in the 1st and 2nd inputs of the Root Password system setting
  4. scroll to the top of the page
  5. press the Save toolbar button
  6. confirm, that:
    • you're automatically scrolled to the 1st validation error
    • a validation error for the Root Password system setting is shown
  7. clear the inputs for the Root Password system setting
  8. scroll to the top of the page
  9. press the Save toolbar button
  10. confirm, that:
    • you're automatically scrolled to the 1st validation error
    • a validation error for the Use Column Freezer system setting is shown

Part 2

  • in IDE:
    1. open the core/units/sections/sections_config.php file for editing
    2. change the template of the in-portal:configure_advanced section from the config/config_universal to config/config_general
    3. save changes
  • in Admin Console:
    1. go to the ToolsSystem Tools section
    2. rebuild the section cache
    3. go to the ConfigurationWebsiteAdvanced section
    4. confirm that the Select Module Root Section system setting is shown
    5. repeat test from the Part 1 part starting from item 2

Part 3

  1. login to the Admin Console
  2. go to the ConfigurationE-commerceGeneral section
  3. change the Select Module Root Section system setting to any section/category, exception HomeProducts
  4. save changes
  5. go to the ConfigurationE-commerceGeneral section (through the item in the tree to ensure full page reload)
  6. confirm that the Select Module Root Section system setting value was properly saved
  7. change the Select Module Root Section system setting to HomeProducts section/category
  8. save changes

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11104
Build 3804: arc lint + arc unit

Event Timeline

alex created this revision.Sat, Jul 19, 7:04 AM
alex requested review of this revision.Sat, Jul 19, 7:04 AM
alex edited the test plan for this revision. (Show Details)Sat, Jul 19, 7:05 AM