Unexpected output: Affected paths: relative - resubmit patch.
⚙ D534 INP-1920 - Ensure consistent named tab preset usage
Page MenuHomeIn-Portal Phabricator

INP-1920 - Ensure consistent named tab preset usage
ClosedPublic

Authored by alex on Mon, Jul 28, 3:41 AM.

Details

Test Plan

Part 1

  1. login to Admin Console
  2. go to the Website & ContentArticles section
  3. click on the New Article toolbar button
  4. confirm, that you see these editing tabs: General, Sections, Relations, Images, Files, Comments, Custom
  5. go to the Website & ContentPolls section
  6. click on the Add toolbar button
  7. confirm, that you see these editing tabs: General, Answers, User Comments

Part 2

  1. login to Admin Console
  2. go to the ConfigurationWebsiteGeneral section
  3. change the Admin Console Interface system setting to adavanced
  4. save changes
  5. go to the Website & ContentForms section
  6. create a form with e-mail communication disabled
  7. create a form with e-mail communication enabled
  8. go to the Website & ContentStructure & Data section
  9. create a section for each of above-created forms
  10. go to Front-End
  11. submit each of the above-created forms
  12. go to Admin Console
  13. for each of the above-created forms:
    1. go to the Website & ContentFormsFN section (the FN is the same of created form)
    2. open submitted form for editing
    3. confirm, that form with disabled e-mail communication doesn't have any editing tabs
    4. confirm, that form with enbled e-mail communication has General and Messages editing tabs

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated
SeverityLocationCodeMessage
Errorcore/units/forms/form_submissions/form_submissions_config.php:91PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/forms/form_submissions/form_submissions_config.php:91PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/forms/form_submissions/form_submissions_config.php:92PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/forms/form_submissions/form_submissions_config.php:92PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errorcore/units/forms/form_submissions/form_submissions_config.php:93PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errorcore/units/forms/form_submissions/form_submissions_config.php:93PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/polls/polls_config.php:145PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/polls/polls_config.php:145PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/polls/polls_config.php:146PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/polls/polls_config.php:146PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/polls/polls_config.php:147PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/polls/polls_config.php:147PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-bulletin/units/polls/polls_config.php:148PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-bulletin/units/polls/polls_config.php:148PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:196PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-news/units/articles/articles_config.php:196PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:197PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-news/units/articles/articles_config.php:197PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:198PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-news/units/articles/articles_config.php:198PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:199PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-news/units/articles/articles_config.php:199PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:200PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-news/units/articles/articles_config.php:200PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-news/units/articles/articles_config.php:201PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Unit
No Unit Test Coverage
Build Status
Buildable 11111
Build 3811: arc lint + arc unit

Event Timeline

alex created this revision.Mon, Jul 28, 3:41 AM
alex requested review of this revision.Mon, Jul 28, 3:41 AM
erik accepted this revision.Mon, Jul 28, 6:37 AM
This revision is now accepted and ready to land.Mon, Jul 28, 6:37 AM
This revision was landed with ongoing or failed builds.Mon, Jul 28, 7:08 AM
This revision was automatically updated to reflect the committed changes.