Unexpected output: Affected paths: relative - resubmit patch.
⚙ D538 MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units
Page MenuHomeIn-Portal Phabricator

MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units
ClosedPublic

Authored by erik on Mon, Aug 4, 6:27 AM.

Details

Summary

fixed notices about missing ID in the OnEntireOrder events

Test Plan

Discounts

  1. login to the adm. console
  2. go to the E-commerceDiscounts & Certificates section
  3. select "Discounts" tab/subsection
  4. press "Add" toolbar button
  5. fill required fields on "Adding Discount ..." form`s "General" tab, go to "Items" tab
  6. press "Entire Order" toolbar button, confirm that "Whole Order" record appeared in the grid
  7. press "Save" toolbar button, confirm that "Items" tab closed and new Discount record appeared in the "Discounts" grid
  8. go to the Logs & ReportsSystem Log section
  9. confirm that no record with notice 'Requested ID for prefix di not passed' appeared in the System Log

Coupons

  1. login to the adm. console
  2. go to the E-commerceDiscounts & Certificates section
  3. select "Coupons" tab/subsection
  4. press "Add" toolbar button
  5. fill required fields on "Adding Coupon ..." form`s "General" tab, go to "Items" tab
  6. press "Entire Order" toolbar button, confirm that "Whole Order" record appeared in the grid
  7. press "Save" toolbar button, confirm that "Items" tab closed and new Coupon record appeared in the "Coupons" grid
  8. go to the Logs & ReportsSystem Log section
  9. confirm that no record with notice 'Requested ID for prefix coupi not passed' appeared in the System Log

Affiliate Plans

  1. apply Affiliate_Plan_Items_Resurrection.patch{F1081323}
  2. login to the adm. console
  3. go to the E-commerceAffiliates section
  4. select "Affiliate Plans" tab/subsection
  5. press "Add" toolbar button
  6. fill required fields on "Adding Affiliate Plan ..." form`s "General" tab, go to "Items" tab
  7. press "Entire Order" toolbar button, confirm that "Whole Order" record appeared in the grid
  8. press "Save" toolbar button, confirm that "Items" tab closed and new Affiliate Plan record appeared in the "Affiliate Plans" grid
  9. go to the Logs & ReportsSystem Log section
  10. confirm that no record with notice 'Requested ID for prefix api not passed' appeared in the System Log

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: fixing all code style errors is not part of this task
SeverityLocationCodeMessage
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:41PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:95PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errormodules/in-commerce/units/affiliate_plans_items/affiliate_plans_items_event_handler.php:95PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/coupon_items/coupon_items_event_handler.php:58PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/discount_items/discount_items_event_handler.php:108PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Unit
No Unit Test Coverage
Build Status
Buildable 11119
Build 3819: arc lint + arc unit

Event Timeline

erik created this revision.Mon, Aug 4, 6:27 AM
erik requested review of this revision.Mon, Aug 4, 6:27 AM
erik edited the test plan for this revision. (Show Details)Mon, Aug 4, 6:29 AM
erik edited the test plan for this revision. (Show Details)Mon, Aug 4, 6:32 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Aug 5, 2:45 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.