Page MenuHomeIn-Portal Phabricator

MINC-213 - Change architecture of the Sales Report generator
AcceptedPublic

Authored by alex on Wed, Dec 10, 12:35 PM.

Details

Reviewers
erik
Test Plan

Test Plan

Preparations

  1. apply the patch from the D547 (if not already applied)
  2. don't apply the patch from THIS differential revision
  3. login to the Admin Console
  4. go to the Website & ContentStructure & DataProducts section
  5. create a Sub Products category/section
  6. switch to the newly created category/section
  7. create a Type=Service product + Status=Active + Price=15.00 product in it
  8. if the product price wasn't saved, then try editing that product -> specifying a price -> saving it again
  9. go to the User ManagementUsers section
  10. create a Status=Enabled user
  11. go to the E-commerceOrders section
  12. switch to the Incomplete tab
  13. create a new incomplete order:
    • use the above-created user and product
    • fill all required fields on all tabs
  14. on the Incomplete tab:
    • select the newly created sales order
    • press the Place Order toolbar button

Test Plan

  1. login to the Admin Console
  2. go to the E-commerceSales Report section
  3. run the report of each type
  4. do the CSV export from the generated report
  5. confirm that each report has non-zero data displayed
  6. remember:
    • how each of the reports looks
    • what data is shown in the report
    • how the exported file is named
    • what is the exported file contents
  7. apply the patch
  8. rebuild the unit config cache for newly added class to be registered
  9. run the report of each report type
  10. do the export of each report type
  11. confirm, that:
    • displayed data (per-report type) match to a previously remembered one
    • the exported filename (per-report type) matches to the previously remembered one
    • exported file contents (per-report type) match to the previously remembered one

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated.
SeverityLocationCodeMessage
Errormodules/in-commerce/constants.php:137PHPCS.E.CodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBraceCodingStandard.Classes.ClassDeclaration.SpaceBeforeCloseBrace
Errormodules/in-commerce/constants.php:137PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExactGeneric.WhiteSpace.ScopeIndent.IncorrectExact
Errormodules/in-commerce/units/reports/reports_config.php:21PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/reports/reports_config.php:21PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/reports/reports_config.php:23PHPCS.E.CodingStandard.Arrays.Array.SpaceAfterKeywordCodingStandard.Arrays.Array.SpaceAfterKeyword
Errormodules/in-commerce/units/reports/reports_config.php:23PHPCS.E.Generic.PHP.LowerCaseKeyword.FoundGeneric.PHP.LowerCaseKeyword.Found
Errormodules/in-commerce/units/reports/reports_event_handler.php:344PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errormodules/in-commerce/units/reports/reports_event_handler.php:345PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/reports/reports_event_handler.php:345PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/reports/reports_event_handler.php:345PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceAfterCodingStandard.Strings.ConcatenationSpacing.NoSpaceAfter
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.CodingStandard.Strings.ConcatenationSpacing.NoSpaceBeforeCodingStandard.Strings.ConcatenationSpacing.NoSpaceBefore
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errormodules/in-commerce/units/reports/reports_event_handler.php:346PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errormodules/in-commerce/units/reports/reports_event_handler.php:347PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndCharCodingStandard.Commenting.InlineComment.InvalidEndChar
Errormodules/in-commerce/units/reports/reports_event_handler.php:347PHPCS.E.CodingStandard.Commenting.InlineComment.NoSpaceBeforeCodingStandard.Commenting.InlineComment.NoSpaceBefore
Errormodules/in-commerce/units/reports/reports_event_handler.php:347PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapitalCodingStandard.Commenting.InlineComment.NotCapital
Errormodules/in-commerce/units/reports/reports_event_handler.php:347PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Unit
No Unit Test Coverage
Build Status
Buildable 11165
Build 3865: arc lint + arc unit

Event Timeline

alex created this revision.Wed, Dec 10, 12:35 PM
alex requested review of this revision.Wed, Dec 10, 12:35 PM
alex edited the test plan for this revision. (Show Details)Wed, Dec 10, 12:36 PM
alex edited the test plan for this revision. (Show Details)
erik accepted this revision.Thu, Dec 11, 4:32 AM
This revision is now accepted and ready to land.Thu, Dec 11, 4:32 AM