Page MenuHomeIn-Portal Phabricator

INP-1859 - Escape MySQL 8.3 keywords
ClosedPublic

Authored by alex on Tue, Dec 9, 9:54 AM.

Details

Test Plan
NOTE: Test on MySQL 8.x (if possible).
  1. login to the Admin Console
  2. go to the Website & ContentStructure & DataProducts section
  3. create a Type=Service product + Status=Active + Price=15.00 product
  4. if the product price wasn't saved, then try editing that product -> specifying a price -> saving it again
  5. go to the E-commerceOrders section
  6. switch to the Incomplete tab
  7. create a new incomplete order (visit all tabs and fill all required fields) with the above-created product
  8. on the Incomplete tab:
    • select the newly created sales order
    • press the Place Order toolbar button
    • confirm that no SQL error has happened
    • confirm that a newly created sales order was moved into the Processed status

Diff Detail

Repository
rMINC Modules.In-Commerce
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Tue, Dec 9, 9:54 AM
alex requested review of this revision.Tue, Dec 9, 9:54 AM
alex edited the test plan for this revision. (Show Details)Tue, Dec 9, 9:56 AM
erik accepted this revision.Tue, Dec 9, 10:20 AM

Without this change - also no SQL error. Maybe, because no MySQL 8.x in the test system.

This revision is now accepted and ready to land.Tue, Dec 9, 10:20 AM
This revision was landed with ongoing or failed builds.Wed, Dec 10, 3:12 AM
Closed by commit rMINC16863: Bug INP-1859 - Escape MySQL 8.3 keywords (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.