Differential D61

MINC-123 - Reset "m_cat_id" web request variable, used in "orditems_PrintList" tag
ClosedPublic
Actions

Authored by alex on Apr 23 2015, 9:30 AM.

Details

Reviewers

glebs

Commits

rMINC16206: Fixes MINC-123 - The "m_cat_id" not reset in "orditems:PrintList" tag

Test Plan

add 2 products to shopping cart
on the Shopping Cart template place following tag before and after PrintCart or PrintList tag usage:

[m_cat_id=<inp2:m_Get name="m_cat_id"/>]

confirm, that number printed from above tag before and after are the same (without patch number after will differ)

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 155.Apr 23 2015, 9:30 AM

alex retitled this revision from to MINC-123 - The "m_cat_id" not reset in "orditems:PrintList" tag.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): MINC-123.

Herald added a reviewer: glebs. · View Herald TranscriptApr 23 2015, 9:30 AM

glebs accepted this revision.May 25 2015, 2:33 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.May 25 2015, 2:33 AM

Closed by commit rMINC16206: Fixes MINC-123 - The "m_cat_id" not reset in "orditems:PrintList" tag (authored by alex). · Explain WhyMay 31 2015, 12:07 PM

This revision was automatically updated to reflect the committed changes.

alex edited edge metadata.Mar 10 2016, 6:12 AM

alex added a project: Restricted Project.

alex retitled this revision from MINC-123 - The "m_cat_id" not reset in "orditems:PrintList" tag to MINC-123 - Reset "m_cat_id" web request variable, used in "orditems:PrintList" tag.Mar 26 2016, 5:48 PM

alex edited the test plan for this revision. (Show Details)

alex retitled this revision from MINC-123 - Reset "m_cat_id" web request variable, used in "orditems:PrintList" tag to MINC-123 - Reset "m_cat_id" web request variable, used in "orditems_PrintList" tag.Jul 16 2016, 6:47 AM

Revision Contents
Changeset List

			Path	Packages
M			modules/in-commerce/units/order_items/order_items_tag_processor.php (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	155	16155		Apr 23 2015, 9:30 AM	★	★
Diff 2	211	16202	Commit rMINC16206	May 31 2015, 12:07 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 155

View Options

modules/in-commerce/units/order_items/order_items_tag_processor.php

MINC-123 - Reset "m_cat_id" web request variable, used in "orditems_PrintList" tagClosedPublicActions