Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F1244230
D216.id510.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Thu, Nov 20, 11:37 PM
Size
1 KB
Mime Type
text/x-diff
Expires
Fri, Nov 21, 11:37 PM (7 h, 36 m)
Engine
blob
Format
Raw Data
Handle
809450
Attached To
D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method
D216.id510.diff
View Options
Index: modules/in-commerce/units/helpers/order_helper.php
===================================================================
--- modules/in-commerce/units/helpers/order_helper.php
+++ modules/in-commerce/units/helpers/order_helper.php
@@ -171,12 +171,33 @@
/**
* Detects credit card type by it's number
*
- * @param string $number
- * @return int
+ * @param string $number Number.
+ *
+ * @return integer
+ *
* @access public
+ * @deprecated
*/
public function getCreditCartType($number)
{
+ trigger_error(
+ 'Usage of deprecated method OrderHelper::getCreditCartType. Use OrderHelper::getCreditCardType.',
+ E_USER_NOTICE
+ );
+
+ return $this->getCreditCardType($number);
+ }
+
+ /**
+ * Detects credit card type by it's number
+ *
+ * @param string $number Number.
+ *
+ * @return integer
+ * @access public
+ */
+ public function getCreditCardType($number)
+ {
// Get rid of any non-digits
$number = preg_replace('/[^\d]/', '', $number);
Index: modules/in-commerce/units/orders/orders_event_handler.php
===================================================================
--- modules/in-commerce/units/orders/orders_event_handler.php
+++ modules/in-commerce/units/orders/orders_event_handler.php
@@ -2537,7 +2537,10 @@
$order_helper = $this->Application->recallObject('OrderHelper');
/* @var $order_helper OrderHelper */
- $object->SetDBField('PaymentCardType', $order_helper->getCreditCartType($object->GetDBField('PaymentAccount')));
+ $object->SetDBField(
+ 'PaymentCardType',
+ $order_helper->getCreditCardType($object->GetDBField('PaymentAccount'))
+ );
}
else {
$object->SetDBField('PaymentCardType', '');
Event Timeline
Log In to Comment