Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F772792
D197.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Sat, Feb 1, 6:44 PM
Size
1 KB
Mime Type
text/x-diff
Expires
Sun, Feb 2, 6:44 PM (6 h, 34 m)
Engine
blob
Format
Raw Data
Handle
556088
Attached To
D197: INP-1533 - Use "EXTR_SKIP" with "extract" function
D197.diff
View Options
Index: branches/5.2.x/core/kernel/db/cat_event_handler.php
===================================================================
--- branches/5.2.x/core/kernel/db/cat_event_handler.php
+++ branches/5.2.x/core/kernel/db/cat_event_handler.php
@@ -1800,7 +1800,7 @@
/* @var $value string */
$type = ucfirst(strtolower($type));
- extract($search_data);
+ extract($search_data, EXTR_SKIP);
switch ($type) {
case 'Field':
Index: branches/5.2.x/core/kernel/nparser/ntags.php
===================================================================
--- branches/5.2.x/core/kernel/nparser/ntags.php
+++ branches/5.2.x/core/kernel/nparser/ntags.php
@@ -206,7 +206,7 @@
$code[] = "\$params = array_merge($defaults, \$params);";
$code[] = "if (!isset(\$params['PrefixSpecial']) && isset(\$params['prefix'])) {\$params['PrefixSpecial'] = \$params['prefix'];};";
- $code[] = "extract(\$params);";
+ $code[] = 'extract($params, EXTR_SKIP);';
$code[] = "\$_parser->SetParams(\$params);";
$code[] = 'ob_start();';
$this->AppendCode($o, $code);
Index: branches/5.2.x/core/units/helpers/site_config_helper.php
===================================================================
--- branches/5.2.x/core/units/helpers/site_config_helper.php
+++ branches/5.2.x/core/units/helpers/site_config_helper.php
@@ -87,7 +87,7 @@
*/
function processConfigChanges($prefix, $changes)
{
- extract($changes);
+ extract($changes, EXTR_SKIP);
$section_adjustments = $this->Application->getUnitOption('core-sections', 'SectionAdjustments', Array ());
$title_presets = $this->Application->getUnitOption($prefix, 'TitlePresets', Array ());
@@ -209,4 +209,4 @@
return $fields;
}
- }
\ No newline at end of file
+ }
Event Timeline
Log In to Comment