Page MenuHomeIn-Portal Phabricator
Differential D279

INP-1596 - Don't autoload object used in "OnSuggestValues" event
ClosedPublic
Actions

Authored by glebs on Jan 3 2017, 4:16 AM.

Details

Reviewers
alex
Commits
rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event
Test Plan
  1. Login to Admin Console
  2. Go to Logs & Reports → System Log and click Delete All to delete all errors.
  3. Go to Website & Content → E-mail Templates
  4. Try to enter existing template name into Template Name filter input. You should see autocomplete dropdown
  5. Go to Logs & Reports → System Log
  6. Confirm you have no new error messages like 'Requested ID for prefix email-template not passed'
  7. Go to Logs & Reports → System Log and click Delete All to delete all errors.
  8. Go to Configuration → Website → General
  9. click Edit link under Website name setting
  10. delete contents of the Section input
  11. Try to enter i into Section input. You should see autocomplete dropdown
  12. Go to Logs & Reports → System Log
  13. Confirm you have no new error messages like 'Requested ID for prefix email-template not passed'

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1105
Build 1105: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 673.Jan 3 2017, 4:16 AM
glebs retitled this revision from to INP-1596 Don't autoload object used in "OnSuggestValues" event.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1596.
alex retitled this revision from INP-1596 Don't autoload object used in "OnSuggestValues" event to INP-1596 - Don't autoload object used in "OnSuggestValues" event.Jul 22 2022, 7:47 AM
alex edited the test plan for this revision. (Show Details)Jul 22 2022, 8:01 AM
alex updated this revision to Diff 1073.Jul 22 2022, 8:03 AM

Updating to match current In-Portal version. Also fixing section auto-complete for the system settings.

alex accepted this revision.Jul 22 2022, 8:04 AM
This revision is now accepted and ready to land.Jul 22 2022, 8:04 AM
Closed by commit rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event (authored by alex, committed by ). · Explain WhyNov 9 2022, 9:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 167316512Jan 3 2017, 4:16 AM
★
★
Diff 2107316722Updating to match current In-Portal version. Also fixing section auto-complete…Jul 22 2022, 8:03 AM
★
★
Diff 3111716745rINP16746Nov 9 2022, 9:36 AM
★
★

Diff 1073

View Options

core/kernel/db/db_event_handler.php

Loading...
View Options

core/units/configuration/configuration_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server