INP-1825 - Show In-Portal-specific superglobals in Debugger
ClosedPublic
Actions

Authored by alex on Sep 8 2022, 9:03 AM.

Details

Reviewers

erik

Commits

Test Plan

in the Admin Console
1. login to the Admin Console
2. go to Configuration → Website → General section
in IDE:
1. open /system/debug.php file for editing
2. uncomment DBG_REDIRECT key of the $dbg_options array
3. save changes
4. open /core/kernel/utility/http_query.php file for editing
5. change $this->Get = $this->AddVars($_GET); into $this->Get = $this->AddVars($_GET + array('virtual_get' => 'virtual_get_val'));
6. change $this->Post = $this->AddVars($_POST); into $this->Post = $this->AddVars($_POST + array('virtual_post' => 'virtual_post_val'));
7. change $this->Cookie = $this->AddVars($_COOKIE); into $this->Cookie = $this->AddVars($_COOKIE + array('virtual_cookie' => 'virtual_cookie_val'));
8. save changes
in the Admin Console
1. press Save button on the toolbar
2. open Debugger by pressing Show Debugger button the Debugger Toolbar
3. confirm, that in Debugger:
  - Web Request information is shown in the usual place
  - there is GE virtual_get virtual_get_val line
  - there is PO virtual_post virtual_post_val line
  - there is CO virtual_cookie virtual_cookie_val line

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Can't fix easily.

Severity	Location	Code	Message
Error	core/kernel/utility/debugger.php:259	PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.PrivateNoUnderscore	CodingStandard.NamingConventions.ValidVariableName.PrivateNoUnderscore
Error	core/kernel/utility/debugger.php:1245	PHPCS.E.PSR2.Methods.FunctionCallSignature.Indent	PSR2.Methods.FunctionCallSignature.Indent
Error	core/kernel/utility/debugger.php:1246	PHPCS.E.PSR2.Methods.FunctionCallSignature.Indent	PSR2.Methods.FunctionCallSignature.Indent
Error	core/kernel/utility/debugger.php:1620	PHPCS.E.CodingStandard.Commenting.InlineComment.InvalidEndChar	CodingStandard.Commenting.InlineComment.InvalidEndChar
Error	core/kernel/utility/debugger.php:1620	PHPCS.E.CodingStandard.Commenting.InlineComment.NotCapital	CodingStandard.Commenting.InlineComment.NotCapital
Warning	core/kernel/utility/debugger.php:1245	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong
Warning	core/kernel/utility/debugger.php:1251	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

No Unit Test Coverage

Build Status

Buildable 1127
Build 1127: arc lint + arc unit

alex requested review of this revision.Sep 8 2022, 9:03 AM

alex added a child revision: Restricted Differential Revision.Sep 8 2022, 9:58 AM

erik accepted this revision.Sep 9 2022, 9:34 AM

This revision is now accepted and ready to land.Sep 9 2022, 9:34 AM

This revision was landed with ongoing or failed builds.Sep 13 2022, 7:31 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1092	16722		Sep 8 2022, 9:03 AM	★	★
Diff 2	1094	16727	rINP16728	Sep 13 2022, 7:31 AM	★	★