Differential D456

INP-1850 - Repair the "kHTTPQuery::getHeaders" method
ClosedPublic
Actions

Authored by alex on Jan 9 2024, 3:55 AM.

Details

Reviewers

erik

Commits

rINP16782: Fixes INP-1850 - Repair the "kHTTPQuery::getHeaders" method

Test Plan

in IDE:
1. open the /index.php file for editing
2. replace the $application->Run(); line with the echo '<pre>', print_r($application->HttpQuery->getHeaders(), true), '</pre>'; line
3. save changes
on the Front-End
1. open website
2. confirm, that displayed array:
  1. contains more than one element
  2. doesn't contain element with Http- key
  3. look similar to the array from the associated Confluence discussion

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1229
Build 1229: arc lint + arc unit

Event Timeline

alex created this revision.Jan 9 2024, 3:55 AM

Herald added a reviewer: erik. · View Herald TranscriptJan 9 2024, 3:55 AM

alex requested review of this revision.Jan 9 2024, 3:55 AM

Harbormaster completed remote builds in B1229: Diff 1185.Jan 9 2024, 3:55 AM

alex added a project: Restricted Project.Jan 9 2024, 3:56 AM

Can't test - local system has apache_request_headers function and test array looks good without patch.

In D456#9259, @erik wrote:

Can't test - local system has apache_request_headers function and test array looks good without patch.

@erik, please comment-out usage of the “apache_request_headers” function in the changed method and continue testing.

erik accepted this revision.Jan 11 2024, 4:07 AM

This revision is now accepted and ready to land.Jan 11 2024, 4:07 AM

Closed by commit rINP16782: Fixes INP-1850 - Repair the "kHTTPQuery::getHeaders" method (authored by alex, committed by ). · Explain WhyJan 15 2024, 3:32 AM

This revision was automatically updated to reflect the committed changes.

alex mentioned this in D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.Jan 24 2024, 6:21 AM

Revision Contents
Changeset List

			Path	Packages
M			core/kernel/utility/http_query.php (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1185	16780		Jan 9 2024, 3:55 AM	★	★
Diff 2	1186	16781	rINP16782	Jan 15 2024, 3:32 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 1185

View Options

core/kernel/utility/http_query.php

INP-1850 - Repair the "kHTTPQuery::getHeaders" methodClosedPublicActions