Details

Reviewers

Commits

rINP16822: Fixes INP-1863 - Correct PHPUnit integration
rMCUS16823: Bug INP-1863 - Correct PHPUnit integration

Test Plan

IMPORTANT: Apply patch using arc patch D494 command, because the Phabricator-generated patch doesn't correctly display file moves, that have no content changes.

Preparations

apply patch from the D496 and D495 (update from 27-Nov-2024: they're committed already; just do svn update)
if you don't have Selenium Server installed/running, then install/run it using instructions from the Preparations section of the D451
in IDE:
- in the core/tests/Functional folder create CoreWorkflowTest.php file with this content:

<?php
class CoreWorkflowTest extends AbstractBrowserTestCase
{

    public function testSample()
    {
        $session = $this->getSession();

        $url = $this->Application->HREF('platform/login/register', '', array('no_amp' => 1));
        $session->visit($url);

        $this->assertTrue(true);
    }

}

- apply changes made (after the patch was applied) to the tools/build/build.properties.dist file onto the tools/build/build.properties file
remove contents of the core/units/helpers/xml_helper.php and core/units/helpers/xml_helper5.php files
in the "tools/build/targets/common.xml" file add these lines after <arg path="${phpunit.config.file}"/> line (4 places) <arg value="--testdox"/> line
in the tools/run_event.php file comment out the exit_code(1, 'This script needs to be enabled manually !'); line
in CLI:
- run the composer install command, to actualize vendor folder content
- ~~run the phing -f tools/build/build_custom.xml db-dump command to create a dump~~
- ~~for each of the build-*.sql files created in the system directory:~~
  - ~~remove the mysqldump: [Warning] Using a password on the command line interface can be insecure. line (if found)~~
  - ~~save changes~~

Part 1 - the PHPUnit isn't used in the default build workflow

delete the "build" folder
run the phing -f tools/build/build_all.xml build command
confirm, by looking at the colorized output of the above command, that phpunit-ci or phpunit targets weren't called
delete the "build" folder
run the phing -f tools/build/build_custom.xml build command
confirm, by looking at the colorized output of the above command, that phpunit-ci or phpunit targets weren't called

Part 2 - core test suite structure testing (via phpunit itself)

run the vendor/bin/phpunit -c tools/build/inc/phpunit.xml --testdox command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...

CoreWorkflow
...

SampleWorkflow
...

run the vendor/bin/phpunit -c tools/build/inc/phpunit.xml --testdox --testsuite Unit command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...

run the vendor/bin/phpunit -c tools/build/inc/phpunit.xml --testdox --testsuite Functional command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

CoreWorkflow
...
SampleWorkflow
...

Part 3 - custom test suite structure testing (via phpunit itself)

run the vendor/bin/phpunit -c tools/build/inc/custom_phpunit.xml --testdox command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

SampleUnit
...

SampleWorkflow
...

run the vendor/bin/phpunit -c tools/build/inc/custom_phpunit.xml --testdox --testsuite Unit command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

SampleUnit
...

run the vendor/bin/phpunit -c tools/build/inc/custom_phpunit.xml --testdox --testsuite Functional command
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: .../tools/build/inc/phpunit.xml

SampleWorkflow
...

Part 4 - core test suite structure testing (via phing's "phpunit" task)

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...

CoreWorkflow
...

SampleWorkflow
...

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit -Dphpunit.testsuite=Unit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit -Dphpunit.testsuite=Functional command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

CoreWorkflow
...

SampleWorkflow
...

Part 5 - core test suite structure testing (via phing's "phpunit-ci" task)

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit-ci command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...

CoreWorkflow
...

SampleWorkflow
...

Generating code coverage report in Clover XML format ... done

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit-ci -Dphpunit.testsuite=Unit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

kFormatter
...

SampleUnit
...


Generating code coverage report in Clover XML format ... done

delete the "build" folder
run the phing -f tools/build/build_all.xml phpunit-ci -Dphpunit.testsuite=Functional command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/phpunit.xml

CoreWorkflow
...

SampleWorkflow
...


Generating code coverage report in Clover XML format ... done

Part 6 - custom test suite structure testing (via phing's "phpunit" task)

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleUnit
...

SampleWorkflow
...

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit -Dphpunit.testsuite=Unit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleUnit
...

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit -Dphpunit.testsuite=Functional command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files doesn't exist
confirm, by looking at the colorized output of the above command, that phpunit target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleWorkflow
...

Part 7 - custom test suite structure testing (via phing's "phpunit-ci" task)

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit-ci command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleUnit
...

SampleWorkflow
...

Generating code coverage report in Clover XML format ... done

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit-ci -Dphpunit.testsuite=Unit command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleUnit
...


Generating code coverage report in Clover XML format ... done

delete the "build" folder
run the phing -f tools/build/build_custom.xml phpunit-ci -Dphpunit.testsuite=Functional command
confirm, that "build/logs/clover.xml" and "build/logs/junit.xml" files were created and they're not empty
confirm, by looking at the colorized output of the above command, that phpunit-ci target was called
confirm, that the output looks similar to this:

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.40 with Xdebug 2.5.5
Configuration: /mnt/UserData/home/alex/web/d/in-portal.52x/tools/build/inc/custom_phpunit.xml

SampleWorkflow
...


Generating code coverage report in Clover XML format ... done

Testing (part 8 - the "/system/mink_config.php" requirement)

move the "mink_config.php" file away from the "/system" folder
run the vendor/bin/phpunit -c tools/build/inc/phpunit.xml command
confirm, that command now fails with "The Mink configuration file does not exist." message (via thrown exception)
move the "mink_config.php" file back to "/system" folder

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1326
Build 1326: arc lint + arc unit

Event Timeline

alex created this revision.Nov 8 2024, 1:11 PM

Herald added a reviewer: erik. · View Herald TranscriptNov 8 2024, 1:11 PM

alex requested review of this revision.Nov 8 2024, 1:11 PM

Harbormaster completed remote builds in B1325: Diff 1275.Nov 8 2024, 1:11 PM

Harbormaster completed remote builds in B1325: Diff 1275.

Updating D494: INP-1863 - Correct PHPUnit integration #
Enter a brief description of the changes included in this update.
The first line is used as subject, next lines as comment. #
Included changes:
M composer.json
M composer.lock
M core/kernel/application.php
V core/tests/AbstractTestCase.php to: core/tests/Unit/AbstractTestCase.php
V core/tests/Unit/AbstractTestCase.php from: core/tests/AbstractTestCase.php
V core/tests/Unit/kernel/utility/formatters/kFormatterTest.php from: core/tests/kernel/utility/formatters/kFormatterTest.php
V core/tests/kernel/utility/formatters/kFormatterTest.php to: core/tests/Unit/kernel/utility/formatters/kFormatterTest.php

Harbormaster completed remote builds in B1326: Diff 1276.Nov 8 2024, 1:20 PM

Harbormaster completed remote builds in B1326: Diff 1276.

Included moved files, that were missing in original diff.

Harbormaster completed remote builds in B1327: Diff 1277.Nov 8 2024, 1:34 PM

alex edited the test plan for this revision. (Show Details)Nov 8 2024, 1:48 PM

Same diff, but file moves in "modules/custom" folder are displayed correctly.

Harbormaster completed remote builds in B1328: Diff 1278.Nov 9 2024, 8:51 AM

alex edited the test plan for this revision. (Show Details)Nov 9 2024, 9:11 AM

Non-obvious Phabricator Differential logic:

the arc patch command svn mv SVN command (file move) as svn cp (file copy) + svn rm (file removal) commands;
directory removal, where file move occurred, isn't marked as removed.

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

In D494#10041, @erik wrote:

Partially tested, tests from part 4 like "confirm, by looking at the colorized output of the above command, that phpunit target was called" - failed. No PHPunit output generated.

@erik , was the build itself successful?

No, build was not successful.

[phingcall] /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:37:41: Task exited with code 1

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:25:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:29:22: Execution of the target buildfile failed. Aborting.

Total time: 29.8418 seconds

alex edited the test plan for this revision. (Show Details)Nov 11 2024, 11:20 AM

In D494#10043, @erik wrote:

No, build was not successful.

[phingcall] /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:37:41: Task exited with code 1

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:25:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/deploy.xml:29:22: Execution of the target buildfile failed. Aborting.

Total time: 29.8418 seconds

I've added this item to the Preparations part of the test plan:

5. in the `tools/run_event.php` file comment out the `exit_code(1, 'This script needs to be enabled manually !');` line

Now the build should be successful.

Can't test because of different php version on VM.

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Image with typical console output is attached.

alex edited the test plan for this revision. (Show Details)Nov 13 2024, 10:15 AM

alex edited the test plan for this revision. (Show Details)

In D494#10047, @erik wrote:

tested, each test command, containing build_all.xml or build_custom.xml leads to config.php change where HMAC key containing variable ($_CONFIG['Misc']['SecurityHmacKey']) disappears, and then build failed due [InvalidArgumentException] "The HMAC key is empty."

Image with typical console output is attached.

@erik , the fix for this issue was done in the D495. Please test that differential revision alone & in combination with this differential revision. Then decide if changes are needed to either of the differential revisions mentioned.

alex added a parent revision: D495: INP-1884 - Actualize "/system/config.php" created during the build.Nov 17 2024, 10:56 AM

alex added a parent revision: D496: INP-1885 - Consistently use PHP binary during the Build.Nov 17 2024, 1:05 PM

alex edited the test plan for this revision. (Show Details)Nov 20 2024, 5:50 AM

Rebasing.

Harbormaster completed remote builds in B1343: Diff 1293.Nov 22 2024, 5:03 AM

Partialy tested, build failed after "run the phing -f tools/build/build_all.xml phpunit command" in the part 4 of test plan

alex edited the test plan for this revision. (Show Details)Mon, Nov 25, 6:00 AM

fixed sh: ${phpunit.testsuite}: bad substitution error
use proper php binary for executing PHPUnit

Harbormaster completed remote builds in B1344: Diff 1294.Mon, Nov 25, 6:36 AM

Speed up code coverage collection 4.25x times by not building coverage report for files, that weren't executed in tests.

Harbormaster completed remote builds in B1346: Diff 1296.Tue, Nov 26, 2:54 AM

Removed debug code, that added from test plan.

Harbormaster completed remote builds in B1347: Diff 1297.Tue, Nov 26, 12:01 PM

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:192:6: /home/sites/ dev/web/SVN/5.2.x/tools/build/targets/common.xml:205:46: Task exited with code 2

Total time: 6 minutes 42.55 seconds

Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

command from 5.7

phing -f tools/build/build_all.xml phpunit-ci -Dphpunit.testsuite=Unit command

had another specific error

build_all.xml phpunit-ci -Dphpunit.testsuite=Unit
Buildfile: tools/build/build_all.xml is not readable!

so, failed all formal requirements after this part (5.8, 5.9, 5.10)

This revision now requires changes to proceed.Wed, Nov 27, 5:45 AM

In D494#10195, @erik wrote:
Failed build at part 4 after command
phing -f tools/build/build_all.xml phpunit
BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:192:6: /home/sites/ dev/web/SVN/5.2.x/tools/build/targets/common.xml:205:46: Task exited with code 2

Total time: 6 minutes 42.55 seconds

I have no idea what causes this (the build log on the screenshot is incomplete), but probably the Selenium Server wasn't running, because couple of PHPUnit tests can' run 6 minutes and that suggests some kind of a timeout error. Please carefully follow the test plan (including preparations phase).

In D494#10196, @erik wrote:
Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

command from 5.7
phing -f tools/build/build_all.xml phpunit-ci -Dphpunit.testsuite=Unit command
had another specific error

build_all.xml phpunit-ci -Dphpunit.testsuite=Unit
Buildfile: tools/build/build_all.xml is not readable!

so, failed all formal requirements after this part (5.8, 5.9, 5.10)

This is happening, because you're running the command in the build/logs folder instead of the project's root folder.

alex requested review of this revision.Wed, Nov 27, 7:40 AM

alex edited the test plan for this revision. (Show Details)Wed, Nov 27, 7:52 AM

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:216:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:235:46: Task exited with code 2

Total time: 31.6997 seconds

At selenium window also some errors displayed -

This revision is now accepted and ready to land.Fri, Nov 29, 4:36 AM

In D494#10203, @erik wrote:
All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.
BUILD FAILED
/home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:216:6: /home/sites/dev/web/SVN/5.2.x/tools/build/targets/common.xml:235:46: Task exited with code 2

Total time: 31.6997 seconds
At selenium window also some errors displayed -

Discussed directly with Erik. The Selenium tests failed because of 2 problems:

The Firefox version was outdated and therefore GeckoDriver was only opening new Browser Window, but wasn't able to perform any actions in it
The /system/config.php file had localhost in it's $_CONFIG['Misc']['Domain'] key and therefore http://localhost/ URL was visited instead of a proper URL

Now everything is fixed.

Closed by commit rINP16822: Fixes INP-1863 - Correct PHPUnit integration (authored by alex, committed by ). · Explain WhySat, Nov 30, 12:56 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1275	16816		Nov 8 2024, 1:11 PM	★	★
Diff 2	1276	16818		Nov 8 2024, 1:20 PM	★	★
Diff 3	1277	16818	Included moved files, that were missing in original diff.	Nov 8 2024, 1:33 PM	★	★
Diff 4	1278	16818	Same diff, but file moves in "modules/custom" folder are displayed correctly.	Nov 9 2024, 8:51 AM	★	★
Diff 5	1293	16821	Rebasing.	Nov 22 2024, 5:03 AM	★	★
Diff 6	1294	16821	1. fixed `sh: ${phpunit.testsuite}: bad substitution`	Mon, Nov 25, 6:36 AM	★	★
Diff 7	1296	16821	Speed up code coverage collection 4.25x times by not building coverage report…	Tue, Nov 26, 2:53 AM	★	★
Diff 8	1297	16821	Removed debug code, that added from test plan.	Tue, Nov 26, 12:01 PM	★	★
Diff 9	1298	16821	rINP16822	Sat, Nov 30, 12:56 PM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Status	Author	Revision
Closed	alex	D494 INP-1863 - Correct PHPUnit integration
Closed	alex	D495 INP-1884 - Actualize "/system/config.php" created during the build
Closed	alex	D496 INP-1885 - Consistently use PHP binary during the Build

D439 INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock

·Branch: /in-portal/branches/5.2.x
·Reviewers: erik

Nov 16 2024, 2:09 PM

Author: alex

		Path
M		composer.json (2 lines)
M		composer.lock (30 lines)
M		core/kernel/application.php (7 lines)
V	M	core/tests/{ → Unit}/AbstractTestCase.php (51 lines)
V		core/tests/{Unit ← }/AbstractTestCase.php
V		core/tests/{Unit ← }/kernel/utility/formatters/kFormatterTest.php
V	M	core/tests/{ → Unit}/kernel/utility/formatters/kFormatterTest.php (63 lines)
A		modules/custom/tests/Functional/SampleWorkflowTest.php
A		modules/custom/tests/PageObject/UserRegistrationPage.php
D	M	modules/custom/tests/SampleUnitTest.php (32 lines)
D	M	modules/custom/tests/SampleWorkflowTest.php (40 lines)
A		modules/custom/tests/Unit/SampleUnitTest.php
D	M	modules/custom/tests/pages/UserRegistrationPage.php (19 lines)
M		modules/custom/tests/tests_config.php (2 lines)
M		tools/build/build.properties.dist (2 lines)
M		tools/build/build_all.xml (1 line)
M		tools/build/build_custom.xml (1 line)
M		tools/build/inc/custom_phpunit.xml (34 lines)
M		tools/build/inc/phpunit.xml (34 lines)
M		tools/build/targets/common.xml (63 lines)

INP-1863 - Correct PHPUnit integration
ClosedPublic
Actions

Details

Preparations

Part 1 - the PHPUnit isn't used in the default build workflow

Part 2 - core test suite structure testing (via phpunit itself)

Part 3 - custom test suite structure testing (via phpunit itself)

Part 4 - core test suite structure testing (via phing's "phpunit" task)

Part 5 - core test suite structure testing (via phing's "phpunit-ci" task)

Part 6 - custom test suite structure testing (via phing's "phpunit" task)

Part 7 - custom test suite structure testing (via phing's "phpunit-ci" task)

Testing (part 8 - the "/system/mink_config.php" requirement)

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1276

composer.json

composer.lock

core/kernel/application.php

core/tests/AbstractTestCase.php

core/tests/Unit/AbstractTestCase.php

core/tests/Unit/kernel/utility/formatters/kFormatterTest.php

core/tests/kernel/utility/formatters/kFormatterTest.php

modules/custom/tests/Functional/SampleWorkflowTest.php

modules/custom/tests/PageObject/UserRegistrationPage.php

modules/custom/tests/SampleUnitTest.php

modules/custom/tests/SampleWorkflowTest.php

modules/custom/tests/Unit/SampleUnitTest.php

modules/custom/tests/pages/UserRegistrationPage.php

modules/custom/tests/tests_config.php

tools/build/build.properties.dist

tools/build/build_all.xml

tools/build/build_custom.xml

tools/build/inc/custom_phpunit.xml

tools/build/inc/phpunit.xml

tools/build/targets/common.xml

INP-1863 - Correct PHPUnit integrationClosedPublicActions

Details

Preparations

Part 1 - the PHPUnit isn't used in the default build workflow

Part 2 - core test suite structure testing (via phpunit itself)

Part 3 - custom test suite structure testing (via phpunit itself)

Part 4 - core test suite structure testing (via phing's "phpunit" task)

Part 5 - core test suite structure testing (via phing's "phpunit-ci" task)

Part 6 - custom test suite structure testing (via phing's "phpunit" task)

Part 7 - custom test suite structure testing (via phing's "phpunit-ci" task)

Testing (part 8 - the "/system/mink_config.php" requirement)

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1276

composer.json

composer.lock

core/kernel/application.php

core/tests/AbstractTestCase.php

core/tests/Unit/AbstractTestCase.php

core/tests/Unit/kernel/utility/formatters/kFormatterTest.php

core/tests/kernel/utility/formatters/kFormatterTest.php

modules/custom/tests/Functional/SampleWorkflowTest.php

modules/custom/tests/PageObject/UserRegistrationPage.php

modules/custom/tests/SampleUnitTest.php

modules/custom/tests/SampleWorkflowTest.php

modules/custom/tests/Unit/SampleUnitTest.php

modules/custom/tests/pages/UserRegistrationPage.php

modules/custom/tests/tests_config.php

tools/build/build.properties.dist

tools/build/build_all.xml

tools/build/build_custom.xml

tools/build/inc/custom_phpunit.xml

tools/build/inc/phpunit.xml

tools/build/targets/common.xml

INP-1863 - Correct PHPUnit integration
ClosedPublic
Actions

Revision Contents
Changeset List