Unexpected output: Affected paths: relative - resubmit patch.
⚙ D481 INP-1873 - Support MySQL 8 database collations
Page MenuHomeIn-Portal Phabricator
Differential D481

INP-1873 - Support MySQL 8 database collations
ClosedPublic
Actions

Authored by alex on Aug 5 2024, 7:38 AM.

Details

Reviewers
erik
Commits
rINP16819: Fixes INP-1873 - Support MySQL 8 database collations
Test Plan

Part 1

  1. delete the /system/config.php file
  2. open the /core/install.php in the Web Browser
  3. perform clean install
  4. on the Database Configuration step:
    1. select Database Collation that doesn't match your MySQL Server version
    2. attempt to proceed to the next installation step
    3. confirm, that a validation error appeared
    4. select Database Collation that does match your MySQL Server version
    5. attempt to proceed to the next installation step
    6. confirm, that no validation error appeared and both DBCharset and DBCollation keys of the /system/config.php are non-empty

Part 2

  1. open the /core/install.php in the Web Browser
  2. select Update Database Configuration option and proceed to the next step
  3. on the Update Database Configuration step:
    1. select Database Collation that doesn't match your MySQL Server version
    2. attempt to proceed to the next installation step
    3. confirm, that a validation error appeared
    4. select Database Collation that does match your MySQL Server version
    5. attempt to proceed to the next installation step
    6. confirm, that no validation error appeared and both DBCharset and DBCollation keys of the /system/config.php are non-empty

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint WarningsExcuse: Not fixing.
SeverityLocationCodeMessage
Warningcore/install.php:571PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningcore/install.php:580PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
No Unit Test Coverage
Build Status
Buildable 1331
Build 1331: arc lint + arc unit

Event Timeline

alex created this revision.Aug 5 2024, 7:38 AM
alex requested review of this revision.Aug 5 2024, 7:38 AM
alex added a project: Restricted Project.Aug 5 2024, 7:38 AM
erik accepted this revision.Aug 5 2024, 9:38 AM
This revision is now accepted and ready to land.Aug 5 2024, 9:38 AM
alex updated this revision to Diff 1281.Nov 17 2024, 10:33 AM
  1. removed support for the utf8mb4_general_ci collection, because you can't even install In-Portal with it due to the ERROR 1071 (42000): Specified key was too long; max key length is 1000 bytes error
  2. rephrase invalid collation message to clearly say "what's wrong" instead of saying "what to do next"
  3. added explanatory message, that tells to use utfmb3_general_ci for MySQL Server 8.x+ versions
Harbormaster completed remote builds in B1331: Diff 1281.Nov 17 2024, 10:33 AM
Harbormaster completed remote builds in B1331: Diff 1281.
alex updated this revision to Diff 1282.Nov 17 2024, 10:36 AM

Fixed a typo (used collation instead of collection word).

This revision was landed with ongoing or failed builds.Nov 17 2024, 10:41 AM
Closed by commit rINP16819: Fixes INP-1873 - Support MySQL 8 database collations (authored by alex, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1123316796Aug 5 2024, 7:38 AM
★
★
Diff 21281168181. removed support for the `utf8mb4_general_ci` collection, because you can't…Nov 17 2024, 10:33 AM
★
★
Diff 3128216818Fixed a typo (used `collation` instead of `collection` word).Nov 17 2024, 10:36 AM
★
★
Diff 4128316818rINP16819Nov 17 2024, 10:41 AM
★
★

Diff 1281

View Options

core/install.php

Loading...
View Options

core/install/step_templates/db_config.tpl

Loading...
View Options

core/install/step_templates/db_reconfig.tpl

Loading...
View Options

core/install/steps_db.xml

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server