Unexpected output: Affected paths: relative - resubmit patch.
⚙ D36 INP-1400 - Store resized images from theme under /system folder
Page MenuHomeIn-Portal Phabricator
Differential D36

INP-1400 - Store resized images from theme under /system folder
ClosedPublic
Actions

Authored by alex on Jan 14 2015, 7:35 AM.

Details

Reviewers
glebs
Commits
rINP16247: Fixes INP-1400 - Store resized images from theme under /system folder
Test Plan
  1. create a Products → sub products category
  2. in that category create:
    • a tangible product without image
    • a tangible product with an image
  3. in the /themes/advanced/in-commerce/elements/products.elm.tpl template change the MaxWidth="thumbnail" to MaxWidth="50" in the product_element block
  4. open created category on Front-End
  5. confirm that both images (default one and uploaded one) were created under /system/thumbs/themes/advanced/platform/img/ folder
  6. go to E-commerce → Manufacturers section in Admin Console
  7. create/update manufacturer and upload a logo
  8. open that manufacturer for editing
  9. confirm that resized image was created under /system/thumbs/system/images/manufacturers/ folder
  10. confirm that clean_resized_catalog_images scheduled task and it's img:OnCleanResizedImages event no longer exists
  11. confirm, that when new file is uploaded the other files older then 1 day are removed from /system/thumbs/system/tmp folder
  12. upgrade In-Portal from any previous version and confirm that any resized sub-folder in any folder under /system were deleted

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Will be fixed in 5.3.x
Unit
No Unit Test Coverage

Event Timeline

alex updated this revision to Diff 91.Jan 14 2015, 7:35 AM
alex retitled this revision from to INP-1400 - Store resized images from theme under /system folder.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1400.
alex updated this revision to Diff 92.Jan 14 2015, 10:26 AM
alex edited edge metadata.

Default image, that was specified using relative path (containing ../) wasn't detected

glebs accepted this revision.Feb 24 2015, 2:07 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 2:07 AM
alex planned changes to this revision.Mar 21 2015, 7:19 AM

Need to cover all resized images as well (see associated discussion in Confluence).

alex edited the test plan for this revision. (Show Details)Mar 21 2015, 2:33 PM
alex edited edge metadata.
alex edited the test plan for this revision. (Show Details)Mar 21 2015, 2:51 PM
alex edited the test plan for this revision. (Show Details)Mar 21 2015, 3:20 PM
alex updated this revision to Diff 144.Mar 21 2015, 3:23 PM
alex edited edge metadata.

Store all thumbnails under /system/thumbs/ folder

glebs accepted this revision.Mar 24 2015, 1:18 PM
glebs edited edge metadata.
This revision is now accepted and ready to land.Mar 24 2015, 1:18 PM
Closed by commit rINP16247: Fixes INP-1400 - Store resized images from theme under /system folder (authored by alex). · Explain WhySep 2 2015, 3:48 PM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:43 AM
alex added a project: Restricted Project.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 19116128Jan 14 2015, 7:35 AM
★
★
Diff 29216128Default image, that was specified using relative path (containing `../`) wasn't detectedJan 14 2015, 10:26 AM
★
★
Diff 314416155Store all thumbnails under /system/thumbs/ folderMar 21 2015, 3:23 PM
★
★
Diff 429316246Commit rINP16247Sep 2 2015, 3:48 PM
★
★

Diff 144

View Options

core/install/upgrades.php

Loading...
View Options

core/kernel/constants.php

Loading...
View Options

core/kernel/db/db_event_handler.php

Loading...
View Options

core/units/helpers/image_helper.php

Loading...
View Options

core/units/images/image_event_handler.php

Loading...
View Options

core/units/images/images_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server